All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cody Kang <codykang.hk@gmail.com>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: "David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Yixun Lan" <dlan@kernel.org>, "Vinod Koul" <vkoul@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Haylen Chu" <heylenay@4d2.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney@redhat.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>, "Yao Zi" <me@ziyao.cc>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Guodong Xu" <docular.xu@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org,
	devicetree@vger.kernel.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 11/17] drm/spacemit: add Saturn DPU DRM device driver
Date: Wed, 18 Nov 2026 23:50:21 +0800	[thread overview]
Message-ID: <aee275aa2ebf093d8518e53c5d264064.codykang.hk@gmail.com> (raw)
In-Reply-To: <e492222feabaa5c72229c93ce75f9500e4346da1.camel@icenowy.me>

Hi Icenowy,

On Thu, 03 Sep 2026 20:07:32 +0800, Icenowy Zheng wrote:
> 在 2026-08-09日的 21:14 +0800,Cody Kang via B4 Relay写道:
> > From: Cody Kang <codykang.hk@gmail.com>
[...]
> > +	drm->mode_config.min_width = 1;
> > +	drm->mode_config.min_height = 1;
> > +	/* K3 user manual: each DPU scans out at most 3840x2160@60
> > */
> > +	drm->mode_config.max_width = 3840;
> > +	drm->mode_config.max_height = 2160;
>
> This is for the biggest possible framebuffer instead of the possible
> scanout pixel count.
>
> The width here should be based on the maximum allowed pitch of the
> display controller instead of the single-GPU maximum size, otherwise it
> won't be able to drive two 3840x2160 screens in a side-by-side
> configuration because this will create a 7680x2160 framebuffer.

Thanks for the review. Agreed; will fix in v3.

v3 will take max_width/max_height from what the RDMA registers can
address (a 16-bit byte stride and 16-bit image dimensions), and move
the 3840x2160 limit into the CRTC's mode_valid.

Cody

WARNING: multiple messages have this Message-ID (diff)
From: Cody Kang <codykang.hk@gmail.com>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: "David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Yixun Lan" <dlan@kernel.org>, "Vinod Koul" <vkoul@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Haylen Chu" <heylenay@4d2.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney@redhat.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>, "Yao Zi" <me@ziyao.cc>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Guodong Xu" <docular.xu@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org,
	devicetree@vger.kernel.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 11/17] drm/spacemit: add Saturn DPU DRM device driver
Date: Wed, 18 Nov 2026 23:50:21 +0800	[thread overview]
Message-ID: <aee275aa2ebf093d8518e53c5d264064.codykang.hk@gmail.com> (raw)
In-Reply-To: <e492222feabaa5c72229c93ce75f9500e4346da1.camel@icenowy.me>

Hi Icenowy,

On Thu, 03 Sep 2026 20:07:32 +0800, Icenowy Zheng wrote:
> 在 2026-08-09日的 21:14 +0800,Cody Kang via B4 Relay写道:
> > From: Cody Kang <codykang.hk@gmail.com>
[...]
> > +	drm->mode_config.min_width = 1;
> > +	drm->mode_config.min_height = 1;
> > +	/* K3 user manual: each DPU scans out at most 3840x2160@60
> > */
> > +	drm->mode_config.max_width = 3840;
> > +	drm->mode_config.max_height = 2160;
>
> This is for the biggest possible framebuffer instead of the possible
> scanout pixel count.
>
> The width here should be based on the maximum allowed pitch of the
> display controller instead of the single-GPU maximum size, otherwise it
> won't be able to drive two 3840x2160 screens in a side-by-side
> configuration because this will create a 7680x2160 framebuffer.

Thanks for the review. Agreed; will fix in v3.

v3 will take max_width/max_height from what the RDMA registers can
address (a 16-bit byte stride and 16-bit image dimensions), and move
the 3840x2160 limit into the CRTC's mode_valid.

Cody

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Cody Kang <codykang.hk@gmail.com>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: "David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Yixun Lan" <dlan@kernel.org>, "Vinod Koul" <vkoul@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Haylen Chu" <heylenay@4d2.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney@redhat.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>, "Yao Zi" <me@ziyao.cc>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Guodong Xu" <docular.xu@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org,
	devicetree@vger.kernel.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 11/17] drm/spacemit: add Saturn DPU DRM device driver
Date: Wed, 18 Nov 2026 23:50:21 +0800	[thread overview]
Message-ID: <aee275aa2ebf093d8518e53c5d264064.codykang.hk@gmail.com> (raw)
In-Reply-To: <e492222feabaa5c72229c93ce75f9500e4346da1.camel@icenowy.me>

Hi Icenowy,

On Thu, 03 Sep 2026 20:07:32 +0800, Icenowy Zheng wrote:
> 在 2026-08-09日的 21:14 +0800,Cody Kang via B4 Relay写道:
> > From: Cody Kang <codykang.hk@gmail.com>
[...]
> > +	drm->mode_config.min_width = 1;
> > +	drm->mode_config.min_height = 1;
> > +	/* K3 user manual: each DPU scans out at most 3840x2160@60
> > */
> > +	drm->mode_config.max_width = 3840;
> > +	drm->mode_config.max_height = 2160;
>
> This is for the biggest possible framebuffer instead of the possible
> scanout pixel count.
>
> The width here should be based on the maximum allowed pitch of the
> display controller instead of the single-GPU maximum size, otherwise it
> won't be able to drive two 3840x2160 screens in a side-by-side
> configuration because this will create a 7680x2160 framebuffer.

Thanks for the review. Agreed; will fix in v3.

v3 will take max_width/max_height from what the RDMA registers can
address (a 16-bit byte stride and 16-bit image dimensions), and move
the 3840x2160 limit into the CRTC's mode_valid.

Cody

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-11-18 15:50 UTC|newest]

Thread overview: 151+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-09 13:14 [PATCH v2 00/17] drm/spacemit: add SpacemiT K3 display support Cody Kang via B4 Relay
2026-08-09 13:14 ` Cody Kang
2026-08-09 13:14 ` Cody Kang via B4 Relay
2026-08-09 13:14 ` Cody Kang via B4 Relay
2026-08-09 13:14 ` [PATCH v2 01/17] dt-bindings: display: spacemit: add K3 Saturn DPU controller Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14 ` [PATCH v2 02/17] dt-bindings: phy: add SpacemiT K3 Innosilicon DP PHY Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14 ` [PATCH v2 03/17] dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:25   ` sashiko-bot
2026-08-09 13:25     ` sashiko-bot
2026-08-09 13:14 ` [PATCH v2 04/17] dt-bindings: soc: spacemit: allow eDP/DP PHY PLL pixel clocks on K3 APMU Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 20:57   ` Rob Herring (Arm)
2026-08-09 20:57     ` Rob Herring (Arm)
2026-08-09 20:57     ` Rob Herring (Arm)
2026-08-10 14:33   ` Rob Herring (Arm)
2026-08-10 14:33     ` Rob Herring (Arm)
2026-08-10 14:33     ` Rob Herring (Arm)
2026-08-09 13:14 ` [PATCH v2 05/17] phy: spacemit: add Innosilicon DP TX PHY driver Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:26   ` sashiko-bot
2026-08-09 13:26     ` sashiko-bot
2026-08-09 13:14 ` [PATCH v2 06/17] clk: spacemit: k3: parent eDP/DP pixel clock to the PHY PLL Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-09-25 14:43   ` Jerome Brunet
2026-09-25 14:43     ` Jerome Brunet
2026-09-25 14:43     ` Jerome Brunet
2026-11-11  4:26     ` Cody Kang
2026-11-11  4:26       ` Cody Kang
2026-11-11  4:26       ` Cody Kang
2026-08-09 13:14 ` [PATCH v2 07/17] drm/spacemit: add Saturn DPU register model Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-09-03 12:08   ` Icenowy Zheng
2026-09-03 12:08     ` Icenowy Zheng
2026-09-03 12:08     ` Icenowy Zheng
2026-11-17 21:48     ` Guodong Xu
2026-11-17 21:48       ` Guodong Xu
2026-11-17 21:48       ` Guodong Xu
2026-11-18 10:18       ` Icenowy Zheng
2026-11-18 10:18         ` Icenowy Zheng
2026-11-18 10:18         ` Icenowy Zheng
2026-11-19 21:38         ` Guodong Xu
2026-11-19 21:38           ` Guodong Xu
2026-11-19 21:38           ` Guodong Xu
2026-08-09 13:14 ` [PATCH v2 08/17] drm/spacemit: add Saturn DPU core types, cmdlist and display MMU Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:32   ` sashiko-bot
2026-08-09 13:32     ` sashiko-bot
2026-09-14 14:10   ` Thomas Zimmermann
2026-09-14 14:10     ` Thomas Zimmermann
2026-09-14 14:10     ` Thomas Zimmermann
2026-11-18 21:03     ` Cody Kang
2026-11-18 21:03       ` Cody Kang
2026-11-18 21:03       ` Cody Kang
2026-08-09 13:14 ` [PATCH v2 09/17] drm/spacemit: add Saturn DPU hardware backend Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:31   ` sashiko-bot
2026-08-09 13:31     ` sashiko-bot
2026-08-09 13:14 ` [PATCH v2 10/17] drm/spacemit: add Saturn DPU KMS pipeline Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:35   ` sashiko-bot
2026-08-09 13:35     ` sashiko-bot
2026-09-14 13:58   ` Thomas Zimmermann
2026-09-14 13:58     ` Thomas Zimmermann
2026-09-14 13:58     ` Thomas Zimmermann
2026-11-18 22:08     ` Cody Kang
2026-11-18 22:08       ` Cody Kang
2026-11-18 22:08       ` Cody Kang
2026-08-09 13:14 ` [PATCH v2 11/17] drm/spacemit: add Saturn DPU DRM device driver Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:35   ` sashiko-bot
2026-08-09 13:35     ` sashiko-bot
2026-09-03 12:07   ` Icenowy Zheng
2026-09-03 12:07     ` Icenowy Zheng
2026-09-03 12:07     ` Icenowy Zheng
2026-11-18 15:50     ` Cody Kang [this message]
2026-11-18 15:50       ` Cody Kang
2026-11-18 15:50       ` Cody Kang
2026-11-10 17:02   ` Sarah Emery
2026-11-10 17:02     ` Sarah Emery
2026-11-10 17:02     ` Sarah Emery
2026-11-11  4:41     ` Cody Kang
2026-11-11  4:41       ` Cody Kang
2026-11-11  4:41       ` Cody Kang
2026-08-09 13:14 ` [PATCH v2 12/17] drm/spacemit: add Innosilicon DP/eDP controller bridge driver Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:36   ` sashiko-bot
2026-08-09 13:36     ` sashiko-bot
2026-08-09 13:14 ` [PATCH v2 13/17] MAINTAINERS: add SpacemiT K3 display driver entry Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14 ` [PATCH v2 14/17] riscv: dts: spacemit: k3: add display nodes Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14 ` [PATCH v2 15/17] riscv: dts: spacemit: k3-pico-itx: enable the DisplayPort output Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:30   ` sashiko-bot
2026-08-09 13:30     ` sashiko-bot
2026-09-03 12:09   ` Icenowy Zheng
2026-09-03 12:09     ` Icenowy Zheng
2026-09-03 12:09     ` Icenowy Zheng
2026-11-17 20:51     ` Guodong Xu
2026-11-17 20:51       ` Guodong Xu
2026-11-17 20:51       ` Guodong Xu
2026-11-18  6:25       ` Icenowy Zheng
2026-11-18  6:25         ` Icenowy Zheng
2026-11-18  6:25         ` Icenowy Zheng
2026-11-18 15:49         ` Cody Kang
2026-11-18 15:49           ` Cody Kang
2026-11-18 15:49           ` Cody Kang
2026-08-09 13:14 ` [PATCH v2 16/17] riscv: dts: spacemit: k3-com260-ifx: " Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14 ` [PATCH v2 17/17] riscv: defconfig: spacemit: k3: enable display driver Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-08-09 13:14   ` Cody Kang via B4 Relay
2026-09-13 18:24 ` [PATCH v2 00/17] drm/spacemit: add SpacemiT K3 display support Ze Huang
2026-09-13 18:24   ` Ze Huang
2026-09-13 18:24   ` Ze Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aee275aa2ebf093d8518e53c5d264064.codykang.hk@gmail.com \
    --to=codykang.hk@gmail.com \
    --cc=airlied@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bmasney@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=docular.xu@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heylenay@4d2.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=me@ziyao.cc \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=spacemit@lists.linux.dev \
    --cc=tzimmermann@suse.de \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=uwu@icenowy.me \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.