From: Chris Wilson <chris@chris-wilson.co.uk>
To: Keith Packard <keithp@keithp.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Skip GPU wait for scanout pin while wedged
Date: Wed, 20 Jul 2011 01:03:17 +0100 [thread overview]
Message-ID: <aefc95$s7qt6@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1311118003-3443-1-git-send-email-keithp@keithp.com>
On Tue, 19 Jul 2011 16:26:43 -0700, Keith Packard <keithp@keithp.com> wrote:
> Failing to pin a scanout buffer will most likely lead to a black
> screen, so if the GPU is wedged, then just let the pin happen and hope
> that things work out OK.
This doesn't prevent us returning an error should the wait-rendering abort
due to a GPU hang occurring in the middle of the wait.
i915_gem_object_pin_to_display_plane is used for more than just the
scanout, cursors and overlay are also included, otherwise we could just
ignore any errors. So,
/* Update the display engine regardless of any GPU hangs */
if (ret == -ERESTARTSYS)
return ret;
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-07-20 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 23:26 [PATCH] drm/i915: Skip GPU wait for scanout pin while wedged Keith Packard
2011-07-20 0:03 ` Chris Wilson [this message]
2011-07-20 0:22 ` Keith Packard
2011-07-29 21:47 ` [PATCH] drm/i915: Ignored GPU wedged errors while pinning scanout buffers Keith Packard
-- strict thread matches above, loose matches on Subject: below --
2011-07-20 0:28 [PATCH] drm/i915: Skip GPU wait for scanout pin while wedged Keith Packard
2011-07-20 22:28 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aefc95$s7qt6@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.