All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/vrr: Stop writing VRR_CTL_IGN_MAX_SHIFT for LNL onwards
@ 2025-04-07  6:37 Jouni Högander
  2025-04-07 11:16 ` Nautiyal, Ankit K
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Jouni Högander @ 2025-04-07  6:37 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: Jouni Högander

According to Bspec VRR_CTL_IGN_MAX_SHIFT doesn't exist for LunarLake and
onwards. Bit 30 is "Mask Block PkgC" instead. Stop writing that for
LunarLake and onwards.

Bspec: 68925

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_vrr.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 633a66f6b73be..ed59e83a3857b 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -444,7 +444,10 @@ static u32 trans_vrr_ctl(const struct intel_crtc_state *crtc_state)
 {
 	struct intel_display *display = to_intel_display(crtc_state);
 
-	if (DISPLAY_VER(display) >= 13)
+	if (DISPLAY_VER(display) >= 20)
+		return VRR_CTL_FLIP_LINE_EN |
+			XELPD_VRR_CTL_VRR_GUARDBAND(crtc_state->vrr.guardband);
+	else if (DISPLAY_VER(display) >= 13)
 		return VRR_CTL_IGN_MAX_SHIFT | VRR_CTL_FLIP_LINE_EN |
 			XELPD_VRR_CTL_VRR_GUARDBAND(crtc_state->vrr.guardband);
 	else
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-04-07 16:24 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07  6:37 [PATCH] drm/i915/vrr: Stop writing VRR_CTL_IGN_MAX_SHIFT for LNL onwards Jouni Högander
2025-04-07 11:16 ` Nautiyal, Ankit K
2025-04-07 11:25   ` Nautiyal, Ankit K
2025-04-07 12:08     ` Hogander, Jouni
2025-04-07 13:46 ` ✓ CI.Patch_applied: success for " Patchwork
2025-04-07 13:46 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-07 13:47 ` ✓ CI.KUnit: success " Patchwork
2025-04-07 13:51 ` ✗ CI.Build: failure " Patchwork
2025-04-07 16:00 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2025-04-07 16:24 ` ✗ i915.CI.BAT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.