All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Frank Li <Frank.Li@nxp.com>,
	alexandre.belloni@bootlin.com, miquel.raynal@bootlin.com,
	conor.culhane@silvaco.com, joe@perches.com,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH 4/5] i3c: master: svc return actual transfer data len
Date: Tue, 17 Oct 2023 11:33:34 +0300	[thread overview]
Message-ID: <af35a533-2126-4a61-a6cd-31ed1e615f2b@linux.intel.com> (raw)
In-Reply-To: <20231016154632.2851957-5-Frank.Li@nxp.com>

Hi

On 10/16/23 18:46, Frank Li wrote:
> I3C allow devices early terminate data transfer. So set "actual" to
> indicate how much data get by i3c_priv_xfer.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>   drivers/i3c/master/svc-i3c-master.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 3570b709cf60..444825aafa6f 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -138,6 +138,7 @@ struct svc_i3c_cmd {
>   	const void *out;
>   	unsigned int len;
>   	unsigned int actual_len;
> +	struct i3c_priv_xfer *xfer;
>   	bool continued;
>   };
>   
I'm thinking would it make sense to combine this and previous patch by 
removing the read_len/actual_len variable from this structure and use 
the added one (by the patch 2/5) from "struct i3c_priv_xfer" directly?

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Frank Li <Frank.Li@nxp.com>,
	alexandre.belloni@bootlin.com, miquel.raynal@bootlin.com,
	conor.culhane@silvaco.com, joe@perches.com,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH 4/5] i3c: master: svc return actual transfer data len
Date: Tue, 17 Oct 2023 11:33:34 +0300	[thread overview]
Message-ID: <af35a533-2126-4a61-a6cd-31ed1e615f2b@linux.intel.com> (raw)
In-Reply-To: <20231016154632.2851957-5-Frank.Li@nxp.com>

Hi

On 10/16/23 18:46, Frank Li wrote:
> I3C allow devices early terminate data transfer. So set "actual" to
> indicate how much data get by i3c_priv_xfer.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>   drivers/i3c/master/svc-i3c-master.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 3570b709cf60..444825aafa6f 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -138,6 +138,7 @@ struct svc_i3c_cmd {
>   	const void *out;
>   	unsigned int len;
>   	unsigned int actual_len;
> +	struct i3c_priv_xfer *xfer;
>   	bool continued;
>   };
>   
I'm thinking would it make sense to combine this and previous patch by 
removing the read_len/actual_len variable from this structure and use 
the added one (by the patch 2/5) from "struct i3c_priv_xfer" directly?

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply	other threads:[~2023-10-17  8:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 15:46 [PATCH 0/5] i3c: master: some improvment for i3c master Frank Li
2023-10-16 15:46 ` Frank Li
2023-10-16 15:46 ` [PATCH 1/5] i3c: master: svc: enable hotjoin default Frank Li
2023-10-16 15:46   ` Frank Li
2023-10-17  6:48   ` Joe Perches
2023-10-17  6:48     ` Joe Perches
2023-10-17 14:04   ` Miquel Raynal
2023-10-17 14:04     ` Miquel Raynal
2023-10-17 14:51     ` Frank Li
2023-10-17 14:51       ` Frank Li
2023-10-17 22:22       ` Alexandre Belloni
2023-10-17 22:22         ` Alexandre Belloni
2023-10-16 15:46 ` [PATCH 2/5] i3c: add actual in i3c_priv_xfer Frank Li
2023-10-16 15:46   ` Frank Li
2023-10-17  6:10   ` Jarkko Nikula
2023-10-17  6:10     ` Jarkko Nikula
2023-10-16 15:46 ` [PATCH 3/5] i3c: svc: rename read_len as actual_len Frank Li
2023-10-16 15:46   ` Frank Li
2023-10-17 14:07   ` Miquel Raynal
2023-10-17 14:07     ` Miquel Raynal
2023-10-17 20:43     ` Frank Li
2023-10-17 20:43       ` Frank Li
2023-10-16 15:46 ` [PATCH 4/5] i3c: master: svc return actual transfer data len Frank Li
2023-10-16 15:46   ` Frank Li
2023-10-17  8:33   ` Jarkko Nikula [this message]
2023-10-17  8:33     ` Jarkko Nikula
2023-10-18 20:18     ` Frank Li
2023-10-18 20:18       ` Frank Li
2023-10-17 14:10   ` Miquel Raynal
2023-10-17 14:10     ` Miquel Raynal
2023-10-18 20:26     ` Frank Li
2023-10-18 20:26       ` Frank Li
2023-10-16 15:46 ` [PATCH 5/5] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li
2023-10-16 15:46   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af35a533-2126-4a61-a6cd-31ed1e615f2b@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor.culhane@silvaco.com \
    --cc=imx@lists.linux.dev \
    --cc=joe@perches.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.