From: "S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] NTB: amd: Silence shift wrapping warning in amd_ntb_db_vector_mask()
Date: Tue, 26 Mar 2019 05:46:44 +0000 [thread overview]
Message-ID: <af8b8b48-ad5e-75c2-d3fe-674b14a0b9af@amd.com> (raw)
In-Reply-To: <20190325092326.GE16023@kadam>
T24gMy8yNS8yMDE5IDI6NTMgUE0sIERhbiBDYXJwZW50ZXIgd3JvdGU6DQo+IFRoaXMgY29kZSB0
cmlnZ2VycyBhIFNtYXRjaCB3YXJuaW5nOg0KPg0KPiAgICAgZHJpdmVycy9udGIvaHcvYW1kL250
Yl9od19hbWQuYzozMzYgYW1kX250Yl9kYl92ZWN0b3JfbWFzaygpDQo+ICAgICB3YXJuOiBzaG91
bGQgJygxIDw8IGRiX3ZlY3RvciknIGJlIGEgNjQgYml0IHR5cGU/DQo+DQo+IEkgZG9uJ3QgdGhp
bmsgImRiX3ZlY3RvciIgY2FuIGJlIGhpZ2hlciB0aGFuIDE2IHNvIHRoaXMgZG9lc24ndCBhZmZl
Y3QNCj4gcnVudGltZSwgYnV0IGl0J3MgbmljZSB0byBzaWxlbmNlIHRoZSBzdGF0aWMgY2hlY2tl
ciB3YXJuaW5nIGFuZCB3ZQ0KPiBtaWdodCBpbmNyZWFzZSAibmRldi0+ZGJfY291bnQiIGluIHRo
ZSBmdXR1cmUuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50
ZXJAb3JhY2xlLmNvbT4NCkFja2VkLWJ5OiBTaHlhbSBTdW5kYXIgUyBLIDxTaHlhbS1zdW5kYXIu
Uy1rQGFtZC5jb20+DQo
WARNING: multiple messages have this Message-ID (diff)
From: "S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>,
"linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] NTB: amd: Silence shift wrapping warning in amd_ntb_db_vector_mask()
Date: Tue, 26 Mar 2019 05:46:44 +0000 [thread overview]
Message-ID: <af8b8b48-ad5e-75c2-d3fe-674b14a0b9af@amd.com> (raw)
In-Reply-To: <20190325092326.GE16023@kadam>
On 3/25/2019 2:53 PM, Dan Carpenter wrote:
> This code triggers a Smatch warning:
>
> drivers/ntb/hw/amd/ntb_hw_amd.c:336 amd_ntb_db_vector_mask()
> warn: should '(1 << db_vector)' be a 64 bit type?
>
> I don't think "db_vector" can be higher than 16 so this doesn't affect
> runtime, but it's nice to silence the static checker warning and we
> might increase "ndev->db_count" in the future.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
next prev parent reply other threads:[~2019-03-26 5:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 9:23 [PATCH] NTB: amd: Silence shift wrapping warning in amd_ntb_db_vector_mask() Dan Carpenter
2019-03-25 9:23 ` Dan Carpenter
2019-03-26 5:46 ` S-k, Shyam-sundar [this message]
2019-03-26 5:46 ` S-k, Shyam-sundar
2019-06-13 13:26 ` Jon Mason
2019-06-13 13:26 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af8b8b48-ad5e-75c2-d3fe-674b14a0b9af@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.