All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-virtualization][PATCH] lxc: delete extraneous PACKAGECONFIG[systemd] line
@ 2026-04-27 20:48 Kris Gavvala
  2026-04-28 11:46 ` Bruce Ashfield
  0 siblings, 1 reply; 2+ messages in thread
From: Kris Gavvala @ 2026-04-27 20:48 UTC (permalink / raw)
  To: meta-virtualization

The PACKAGECONFIG[systemd] variable is assigned twice, with the second assignment overriding the first.
This patch removes the unused assignment to avoid confusion.

The duplication was introduced in an August 25, 2022 patch:
	05f316f7 lxc: update to 5.x and meson

Verfied that the build did not change after this deletion by checking the log files before and after
and finding the same message:

	export systemd_system_unitdir="/usr/lib/systemd/system"
	export systemd_unitdir="/usr/lib/systemd"
	export systemd_user_unitdir="/usr/lib/systemd/user"

Signed-off-by: Kris Gavvala <kris.gavvala@windriver.com>
---
 recipes-containers/lxc/lxc_git.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/recipes-containers/lxc/lxc_git.bb b/recipes-containers/lxc/lxc_git.bb
index f08d793d..3de9a8e9 100644
--- a/recipes-containers/lxc/lxc_git.bb
+++ b/recipes-containers/lxc/lxc_git.bb
@@ -80,7 +80,6 @@ PACKAGECONFIG[apparmor] = "-Dapparmor=true,-Dapparmor=false,apparmor,apparmor"
 PACKAGECONFIG[templates] = ",,, ${PN}-templates"
 PACKAGECONFIG[selinux] = "-Dselinux=true,-Dselinux=false,libselinux,libselinux"
 PACKAGECONFIG[seccomp] = "-Dseccomp=true,-Dseccomp=false,libseccomp,libseccomp"
-PACKAGECONFIG[systemd] = "-Dsystemd-unitdir=${sysconfdir}/systemd/system/, -Dsystemd-unitdir=, systemd,"
 PACKAGECONFIG[systemd] = "-Dinit-script=systemd,-Dinit-script=sysvinit,systemd,"
 
 # required by python3 to run setup.py
-- 
2.49.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [meta-virtualization][PATCH] lxc: delete extraneous PACKAGECONFIG[systemd] line
  2026-04-27 20:48 [meta-virtualization][PATCH] lxc: delete extraneous PACKAGECONFIG[systemd] line Kris Gavvala
@ 2026-04-28 11:46 ` Bruce Ashfield
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Ashfield @ 2026-04-28 11:46 UTC (permalink / raw)
  To: Kris.Gavvala; +Cc: meta-virtualization

In message: [meta-virtualization][PATCH] lxc: delete extraneous PACKAGECONFIG[systemd] line
on 27/04/2026 Gavvala, Kris via lists.yoctoproject.org wrote:

> The PACKAGECONFIG[systemd] variable is assigned twice, with the second assignment overriding the first.
> This patch removes the unused assignment to avoid confusion.
> 
> The duplication was introduced in an August 25, 2022 patch:
> 	05f316f7 lxc: update to 5.x and meson

Ha! I messed that up some time ago :)

Thanks for the fix, it is merged to master

Bruce

> 
> Verfied that the build did not change after this deletion by checking the log files before and after
> and finding the same message:
> 
> 	export systemd_system_unitdir="/usr/lib/systemd/system"
> 	export systemd_unitdir="/usr/lib/systemd"
> 	export systemd_user_unitdir="/usr/lib/systemd/user"
> 
> Signed-off-by: Kris Gavvala <kris.gavvala@windriver.com>
> ---
>  recipes-containers/lxc/lxc_git.bb | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/recipes-containers/lxc/lxc_git.bb b/recipes-containers/lxc/lxc_git.bb
> index f08d793d..3de9a8e9 100644
> --- a/recipes-containers/lxc/lxc_git.bb
> +++ b/recipes-containers/lxc/lxc_git.bb
> @@ -80,7 +80,6 @@ PACKAGECONFIG[apparmor] = "-Dapparmor=true,-Dapparmor=false,apparmor,apparmor"
>  PACKAGECONFIG[templates] = ",,, ${PN}-templates"
>  PACKAGECONFIG[selinux] = "-Dselinux=true,-Dselinux=false,libselinux,libselinux"
>  PACKAGECONFIG[seccomp] = "-Dseccomp=true,-Dseccomp=false,libseccomp,libseccomp"
> -PACKAGECONFIG[systemd] = "-Dsystemd-unitdir=${sysconfdir}/systemd/system/, -Dsystemd-unitdir=, systemd,"
>  PACKAGECONFIG[systemd] = "-Dinit-script=systemd,-Dinit-script=sysvinit,systemd,"
>  
>  # required by python3 to run setup.py
> -- 
> 2.49.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9747): https://lists.yoctoproject.org/g/meta-virtualization/message/9747
> Mute This Topic: https://lists.yoctoproject.org/mt/119038529/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-28 11:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27 20:48 [meta-virtualization][PATCH] lxc: delete extraneous PACKAGECONFIG[systemd] line Kris Gavvala
2026-04-28 11:46 ` Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.