All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wander Lairson Costa <wander@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	 Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	 Valentin Schneider <vschneid@redhat.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	 "open list:SCHEDULER" <linux-kernel@vger.kernel.org>,
	"open list:TRACING" <linux-trace-kernel@vger.kernel.org>,
	 acme@kernel.org, williams@redhat.com, gmonaco@redhat.com
Subject: Re: [PATCH v3 1/4] tracing/preemptirq: Optimize preempt_disable/enable() tracepoint overhead
Date: Tue, 28 Apr 2026 16:05:47 -0300	[thread overview]
Message-ID: <afEE8OVPEA_UFpIF@192.168.0.21> (raw)
In-Reply-To: <20260428145151.3860aa04@gandalf.local.home>

On Tue, Apr 28, 2026 at 02:51:51PM -0400, Steven Rostedt wrote:
> On Fri, 13 Mar 2026 12:36:10 -0300
> Wander Lairson Costa <wander@redhat.com> wrote:
> 
> > On Fri, Mar 13, 2026 at 10:04:04AM +0100, Peter Zijlstra wrote:
> > > On Thu, Mar 12, 2026 at 02:19:15PM -0300, Wander Lairson Costa wrote:
> > >   
> > > > > That's significant bloat, for really very little gain. Realistically
> > > > > nobody is going to need these.
> > > > >   
> > > > 
> > > > Of course, I can't speak for others, but more than once I debugged issues
> > > > that those tracepoints had made my life far easier. Those cases convinced
> > > > me that such a feature would be worth it. But if you don't see
> > > > value and will reject the patches no matter what, nothing can be done,
> > > > and I will have to accept defeat.  
> > > 
> > > If distros are going to enable this, I suppose I'm not going to stop
> > > this. But I do very much worry about the general bloat of things, there
> > > are a *LOT* of preempt_{dis,en}able() sites.
> > >   
> > 
> > We plan to enable these tracepoints in the RHEL kernel-rt to track
> > extended non-preemptible states that cause high latencies. These
> > issues occasionally surface in customer OpenShift deployments, where
> > deploying a custom debug kernel is highly impractical. Having these
> > tracepoints available in the distribution kernel would be handful for
> > debugging these production systems. That said, I expect enabling this
> > feature to be the exception rather than the rule — most distribution
> > kernels would leave it disabled.
> 
> Is this work going to continue? Or should I just change the status to
> "reject" in patchwork?
> 

Yes, I am still working on it and should have a v4 soon.

> -- Steve
> 


  reply	other threads:[~2026-04-28 19:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 12:50 [PATCH v3 0/4] tracing/preemptirq: Optimize disabled tracepoint overhead Wander Lairson Costa
2026-03-11 12:50 ` [PATCH v3 1/4] tracing/preemptirq: Optimize preempt_disable/enable() " Wander Lairson Costa
2026-03-11 19:35   ` Peter Zijlstra
2026-03-12 17:19     ` Wander Lairson Costa
2026-03-13  9:04       ` Peter Zijlstra
2026-03-13 15:36         ` Wander Lairson Costa
2026-04-28 18:51           ` Steven Rostedt
2026-04-28 19:05             ` Wander Lairson Costa [this message]
2026-03-11 12:50 ` [PATCH v3 2/4] trace/preemptirq: make TRACE_PREEMPT_TOGGLE user-selectable Wander Lairson Costa
2026-03-11 12:50 ` [PATCH v3 3/4] trace/preemptirq: add TRACE_IRQFLAGS_TOGGLE Wander Lairson Costa
2026-03-11 12:50 ` [PATCH v3 4/4] trace/preemptirq: Implement trace_irqflags hooks Wander Lairson Costa
2026-03-11 19:43   ` Peter Zijlstra
2026-03-11 19:48     ` Steven Rostedt
2026-03-11 19:53       ` Peter Zijlstra
2026-03-11 20:07         ` Steven Rostedt
2026-03-11 20:46           ` Peter Zijlstra
2026-03-11 23:16             ` Steven Rostedt
2026-03-12 17:09     ` Wander Lairson Costa
2026-04-28 18:54     ` Steven Rostedt
2026-04-28 19:04       ` Wander Lairson Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afEE8OVPEA_UFpIF@192.168.0.21 \
    --to=wander@redhat.com \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gmonaco@redhat.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mgorman@suse.de \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.