From: Peng Fan <peng.fan@oss.nxp.com>
To: Ye Li <ye.li@nxp.com>
Cc: radu-nicolae.pirea@oss.nxp.com, u-boot@lists.denx.de,
peng.fan@nxp.com, uboot-imx@nxp.com
Subject: Re: [PATCH] net: phy: nxp-c45-tja11xx: Fix incorrect usage of devm_kzalloc
Date: Wed, 29 Apr 2026 10:30:22 +0800 [thread overview]
Message-ID: <afFtPvydwmsKEEnx@shlinux89> (raw)
In-Reply-To: <20260428083733.1803100-1-ye.li@nxp.com>
On Tue, Apr 28, 2026 at 04:37:33PM +0800, Ye Li wrote:
>devm_kzalloc needs to pass udevice for first parameter, this phy driver
>wrongly pass the priv in phy_device. And because the dev in phy_device
>is only valid after phy_connect, in probe phase this dev is NULL, so
>we can't use devm_kzalloc, replace it with kzalloc.
>
>Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
prev parent reply other threads:[~2026-04-29 2:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 8:37 [PATCH] net: phy: nxp-c45-tja11xx: Fix incorrect usage of devm_kzalloc Ye Li
2026-04-29 2:30 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afFtPvydwmsKEEnx@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=peng.fan@nxp.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.