* [PATCH] net: phy: nxp-c45-tja11xx: Fix incorrect usage of devm_kzalloc
@ 2026-04-28 8:37 Ye Li
2026-04-29 2:30 ` Peng Fan
0 siblings, 1 reply; 2+ messages in thread
From: Ye Li @ 2026-04-28 8:37 UTC (permalink / raw)
To: radu-nicolae.pirea, u-boot; +Cc: peng.fan, uboot-imx
devm_kzalloc needs to pass udevice for first parameter, this phy driver
wrongly pass the priv in phy_device. And because the dev in phy_device
is only valid after phy_connect, in probe phase this dev is NULL, so
we can't use devm_kzalloc, replace it with kzalloc.
Signed-off-by: Ye Li <ye.li@nxp.com>
---
drivers/net/phy/nxp-c45-tja11xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
index a1e4c3d053b..9814ac498ed 100644
--- a/drivers/net/phy/nxp-c45-tja11xx.c
+++ b/drivers/net/phy/nxp-c45-tja11xx.c
@@ -343,7 +343,7 @@ static int nxp_c45_probe(struct phy_device *phydev)
{
struct nxp_c45_phy *priv;
- priv = devm_kzalloc(phydev->priv, sizeof(*priv), GFP_KERNEL);
+ priv = kzalloc(sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: phy: nxp-c45-tja11xx: Fix incorrect usage of devm_kzalloc
2026-04-28 8:37 [PATCH] net: phy: nxp-c45-tja11xx: Fix incorrect usage of devm_kzalloc Ye Li
@ 2026-04-29 2:30 ` Peng Fan
0 siblings, 0 replies; 2+ messages in thread
From: Peng Fan @ 2026-04-29 2:30 UTC (permalink / raw)
To: Ye Li; +Cc: radu-nicolae.pirea, u-boot, peng.fan, uboot-imx
On Tue, Apr 28, 2026 at 04:37:33PM +0800, Ye Li wrote:
>devm_kzalloc needs to pass udevice for first parameter, this phy driver
>wrongly pass the priv in phy_device. And because the dev in phy_device
>is only valid after phy_connect, in probe phase this dev is NULL, so
>we can't use devm_kzalloc, replace it with kzalloc.
>
>Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-29 2:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28 8:37 [PATCH] net: phy: nxp-c45-tja11xx: Fix incorrect usage of devm_kzalloc Ye Li
2026-04-29 2:30 ` Peng Fan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.