Re: [PATCH v2 7/7] ufs: qcom: Remove redundant POST_CHANGE clock setup call

[Sumit Garg <sumit.garg@kernel.org>]

On Mon, Apr 27, 2026 at 02:56:11PM +0530, Balaji Selvanathan wrote:
> The ufs_qcom_init() function was calling ufs_qcom_setup_clocks() with
> POST_CHANGE twice. The first call after setting PA_TXHSADAPTTYPE
> correctly enables the device reference clock. The second call after
> ufs_qcom_advertise_quirks() is redundant as the clock is already
> enabled.
> 
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> ---
> Changes in v2:
> - Newly added in v2
> ---
>  drivers/ufs/ufs-qcom.c | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> diff --git a/drivers/ufs/ufs-qcom.c b/drivers/ufs/ufs-qcom.c
> index ae33f62fbee..f5f5a6eb110 100644
> --- a/drivers/ufs/ufs-qcom.c
> +++ b/drivers/ufs/ufs-qcom.c
> @@ -605,7 +605,6 @@ static int ufs_qcom_init(struct ufs_hba *hba)
>  		 priv->hw_ver.step);
>  
>  	ufs_qcom_advertise_quirks(hba);
> -	ufs_qcom_setup_clocks(hba, true, POST_CHANGE);
>  
>  	return 0;
>  }
> 
> -- 
> 2.34.1
>