From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Alexander Larsson <alexl@redhat.com>,
Jingbo Xu <jefflexu@linux.alibaba.com>
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
huyue2@coolpad.com
Subject: Re: [PATCH v2 2/2] erofs: boost negative xattr lookup with bloom filter
Date: Wed, 5 Jul 2023 15:55:45 +0800 [thread overview]
Message-ID: <afa51f3e-5ac8-86bd-364e-f55706c40470@linux.alibaba.com> (raw)
In-Reply-To: <CAL7ro1GuPZE8ek=uvfHEqGFrbbt=NO1=oO8_B-dVBF9go=StSg@mail.gmail.com>
On 2023/7/5 15:44, Alexander Larsson wrote:
> On Wed, Jul 5, 2023 at 9:04 AM Jingbo Xu <jefflexu@linux.alibaba.com> wrote:
...
>> + if (erofs_sb_has_xattr_filter(sbi)) {
>
> As I said in my other mail. I would really like this to just always do
> the filter check. It should be safe as older fs:es have zero in place
> here, and doing this allows me to create composefs images with the
> bloom filters that also work with older kernels.
As my previous email, this flag is on-disk compatible which means old
unsupported kernels will just ignore this and go on mounting.
But this flag indicates a new on-disk feature in the image anyway,
users could know if an image uses the new feature rather than seek to
individual inodes.
Does it sound reasonable or some other consideration?
Thanks,
Gao Xiang
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Alexander Larsson <alexl@redhat.com>,
Jingbo Xu <jefflexu@linux.alibaba.com>
Cc: chao@kernel.org, huyue2@coolpad.com,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] erofs: boost negative xattr lookup with bloom filter
Date: Wed, 5 Jul 2023 15:55:45 +0800 [thread overview]
Message-ID: <afa51f3e-5ac8-86bd-364e-f55706c40470@linux.alibaba.com> (raw)
In-Reply-To: <CAL7ro1GuPZE8ek=uvfHEqGFrbbt=NO1=oO8_B-dVBF9go=StSg@mail.gmail.com>
On 2023/7/5 15:44, Alexander Larsson wrote:
> On Wed, Jul 5, 2023 at 9:04 AM Jingbo Xu <jefflexu@linux.alibaba.com> wrote:
...
>> + if (erofs_sb_has_xattr_filter(sbi)) {
>
> As I said in my other mail. I would really like this to just always do
> the filter check. It should be safe as older fs:es have zero in place
> here, and doing this allows me to create composefs images with the
> bloom filters that also work with older kernels.
As my previous email, this flag is on-disk compatible which means old
unsupported kernels will just ignore this and go on mounting.
But this flag indicates a new on-disk feature in the image anyway,
users could know if an image uses the new feature rather than seek to
individual inodes.
Does it sound reasonable or some other consideration?
Thanks,
Gao Xiang
next prev parent reply other threads:[~2023-07-05 7:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 7:04 [PATCH v2 0/2] erofs: introduce xattr name bloom filter Jingbo Xu
2023-07-05 7:04 ` [PATCH v2 1/2] erofs: update on-disk format for xattr name filter Jingbo Xu
2023-07-05 7:24 ` Gao Xiang
2023-07-05 7:43 ` Alexander Larsson
2023-07-05 7:43 ` Alexander Larsson
2023-07-05 7:51 ` Gao Xiang
2023-07-05 7:51 ` Gao Xiang
2023-07-05 8:12 ` Alexander Larsson
2023-07-05 8:12 ` Alexander Larsson
2023-07-05 8:13 ` Gao Xiang
2023-07-05 8:13 ` Gao Xiang
2023-07-05 7:04 ` [PATCH v2 2/2] erofs: boost negative xattr lookup with bloom filter Jingbo Xu
2023-07-05 7:44 ` Alexander Larsson
2023-07-05 7:44 ` Alexander Larsson
2023-07-05 7:55 ` Gao Xiang [this message]
2023-07-05 7:55 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afa51f3e-5ac8-86bd-364e-f55706c40470@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=alexl@redhat.com \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.