All of lore.kernel.org
 help / color / mirror / Atom feed
From: abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
To: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-arm-msm-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] drm/msm: Don't fail bind if nothing connected to dsi
Date: Mon, 30 Jul 2018 15:30:28 -0700	[thread overview]
Message-ID: <afba28699fce6642df1ed59d194c53bf@codeaurora.org> (raw)
In-Reply-To: <20180730152658.157098-4-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

On 2018-07-30 08:26, Sean Paul wrote:
> If there is no bridge or panel connected to a dsi node, don't fail the
> entire msm bind. Just ignore the dsi block and move on.
> 
> Cc: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/dsi/dsi.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dsi/dsi.c 
> b/drivers/gpu/drm/msm/dsi/dsi.c
> index ee07d58c2d97..a9768f823290 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi.c
> @@ -118,8 +118,13 @@ static int dsi_bind(struct device *dev, struct
> device *master, void *data)
> 
>  	DBG("");
>  	msm_dsi = dsi_init(pdev);
> -	if (IS_ERR(msm_dsi))
> -		return PTR_ERR(msm_dsi);
> +	if (IS_ERR(msm_dsi)) {
> +		/* Don't fail the bind if the dsi port is not connected */
> +		if (PTR_ERR(msm_dsi) == -ENODEV)
> +			return 0;
> +		else
> +			return PTR_ERR(msm_dsi);
> +	}
> 
>  	priv->dsi[msm_dsi->id] = msm_dsi;
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

      parent reply	other threads:[~2018-07-30 22:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 15:26 [PATCH 0/3] drm/msm: dsi: Properly handle disconnected secondary dsi block Sean Paul
     [not found] ` <20180730152658.157098-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-07-30 15:26   ` [PATCH 1/3] drm/msm: dsi: Initialize msm_dsi->id to -1 Sean Paul
     [not found]     ` <20180730152658.157098-2-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-07-30 22:29       ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
2018-07-30 15:26   ` [PATCH 2/3] drm/msm: dsi: Return errors whan dt parsing fails Sean Paul
     [not found]     ` <20180730152658.157098-3-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-07-30 22:30       ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ
2018-07-30 15:26   ` [PATCH 3/3] drm/msm: Don't fail bind if nothing connected to dsi Sean Paul
     [not found]     ` <20180730152658.157098-4-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-07-30 22:30       ` abhinavk-sgV2jX0FEOL9JmXXK+q4OQ [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afba28699fce6642df1ed59d194c53bf@codeaurora.org \
    --to=abhinavk-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
    --cc=architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-arm-msm-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.