Re: [PATCH 2/3] drm/msm: dsi: Return errors whan dt parsing fails

[abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org]

On 2018-07-30 08:26, Sean Paul wrote:
> If dt parsing fails, we should return an error instead of pretending
> everything completed successfully.
> 
> Cc: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Thanks for fixing this !
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
> b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 96fb5f635314..9c6c523eacdc 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -1750,6 +1750,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host
> *msm_host)
>  	if (ret) {
>  		dev_err(dev, "%s: invalid lane configuration %d\n",
>  			__func__, ret);
> +		ret = -EINVAL;
>  		goto err;
>  	}
> 
> @@ -1757,6 +1758,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host
> *msm_host)
>  	device_node = of_graph_get_remote_node(np, 1, 0);
>  	if (!device_node) {
>  		dev_dbg(dev, "%s: no valid device\n", __func__);
> +		ret = -ENODEV;
>  		goto err;
>  	}
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno