From: Jonathan Cameron <jic23@kernel.org>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
geert@linux-m68k.org, wsa+renesas@sang-engineering.com,
magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: linux-iio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/4] iio: Documentation: Add max9611 sysfs documentation
Date: Sun, 2 Apr 2017 10:53:45 +0100 [thread overview]
Message-ID: <afc46629-683b-1d28-4e76-ce10f372cb90@kernel.org> (raw)
In-Reply-To: <6b249f47-2a79-e9a0-0599-284301319a9d@kernel.org>
On 02/04/17 10:36, Jonathan Cameron wrote:
> On 27/03/17 16:12, Jacopo Mondi wrote:
>> Add documentation for max9611 driver.
>> Document attributes describing value of shunt resistor installed between
>> RS+ and RS- voltage sense inputs.
>>
>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Good. Will pick up once the binding is sorted.
>
> Kick me if I don't!
Oops. Missed the units being micro ohms. They want to be ohms to be consistent
within the ABI.
We let various odd units go in right back at the beginning to try and remain
compatible with hwmon. Turned out to be a bad idea. Also the ina2xx uses
ohms and you should stay consistent with that.
Thanks,
Jonathan
>> ---
>> Documentation/ABI/testing/sysfs-bus-iio-adc-max9611 | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-max9611
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-max9611 b/Documentation/ABI/testing/sysfs-bus-iio-adc-max9611
>> new file mode 100644
>> index 0000000..5020d00
>> --- /dev/null
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio-adc-max9611
>> @@ -0,0 +1,17 @@
>> +What: /sys/bus/iio/devices/iio:deviceX/in_power_shunt_resistor
>> +Date: March 2017
>> +KernelVersion: 4.12
>> +Contact: linux-iio@vger.kernel.org
>> +Description: The value of the shunt resistor used to compute power drain on
>> + common input voltage pin (RS+). In micro Ohms.
>> +
>> +What: /sys/bus/iio/devices/iio:deviceX/in_current_shunt_resistor
>> +Date: March 2017
>> +KernelVersion: 4.12
>> +Contact: linux-iio@vger.kernel.org
>> +Description: The value of the shunt resistor used to compute current flowing
>> + between RS+ and RS- voltage sense inputs. In micro Ohms.
>> +
>> +These attributes describe a single physical component, exposed as two distinct
>> +attributes as it is used to calculate two different values: power load and
>> +current flowing between RS+ and RS- inputs.
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-04-02 9:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 15:12 [PATCH v4 0/4] iio: adc: Maxim max9611 driver Jacopo Mondi
2017-03-27 15:12 ` Jacopo Mondi
2017-03-27 15:12 ` [PATCH v4 1/4] Documentation: dt-bindings: iio: Add max9611 ADC Jacopo Mondi
2017-03-27 15:12 ` Jacopo Mondi
2017-04-02 9:35 ` Jonathan Cameron
2017-04-03 13:26 ` Rob Herring
2017-03-27 15:12 ` [PATCH v4 2/4] iio: Documentation: Add max9611 sysfs documentation Jacopo Mondi
2017-03-27 15:12 ` Jacopo Mondi
2017-04-02 9:36 ` Jonathan Cameron
2017-04-02 9:53 ` Jonathan Cameron [this message]
2017-03-27 15:12 ` [PATCH v4 3/4] iio: adc: Add Maxim max9611 ADC driver Jacopo Mondi
2017-03-27 15:12 ` Jacopo Mondi
2017-04-02 9:43 ` Jonathan Cameron
2017-04-02 9:43 ` Jonathan Cameron
2017-03-27 15:12 ` [PATCH v4 4/4] arm64: dts: salvator-x: Add current sense amplifiers Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afc46629-683b-1d28-4e76-ce10f372cb90@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=jacopo+renesas@jmondi.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.