From: Jonathan Cameron <jic23@kernel.org>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
geert@linux-m68k.org, wsa+renesas@sang-engineering.com,
magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: linux-iio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/4] Documentation: dt-bindings: iio: Add max9611 ADC
Date: Sun, 2 Apr 2017 10:35:40 +0100 [thread overview]
Message-ID: <eeffe49b-7f70-0cad-88c4-76b3e5807b7b@kernel.org> (raw)
In-Reply-To: <1490627578-15938-2-git-send-email-jacopo+renesas@jmondi.org>
On 27/03/17 16:12, Jacopo Mondi wrote:
> Add device tree bindings documentation for Maxim max9611/max9612 current
> sense amplifier.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> .../devicetree/bindings/iio/adc/max9611.txt | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/max9611.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/max9611.txt b/Documentation/devicetree/bindings/iio/adc/max9611.txt
> new file mode 100644
> index 0000000..8430d3b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/max9611.txt
> @@ -0,0 +1,26 @@
> +* Maxim max9611/max9612 current sense amplifier with 12-bits ADC interface
> +
> +Maxim max9611/max9612 is an high-side current sense amplifier with integrated
> +12-bits ADC communicating over I2c bus.
> +The device node for this driver shall be a child of a I2c controller.
> +
> +Required properties
> + - compatible: Should be "maxim,max9611" or "maxim,max9612"
> + - reg: The 7-bits long I2c address of the device
> + - shunt-resistor-uohm: Value, in uOhm, of the current sense shunt resistor
Just did a quick grep for this see if I felt comfortable enough to
not wait for Rob / Mark to have a chance to look at it.
Grep gave me:
shunt-resistor-micro-ohms for the ina2xx.
Feels rather like we should match that.
Otherwise looks good to me.
Jonathan
> +
> +Example:
> +
> +&i2c4 {
> + csa: adc@7c {
> + compatible = "maxim,max9611";
> + reg = <0x7c>;
> +
> + shunt-resistor-uohm = <5000>;
> + };
> +};
> +
> +This device node describes a current sense amplifier sitting on I2c4 bus
> +with address 0x7c (read address is 0xf9, write address is 0xf8).
> +A sense resistor of 0,005 Ohm is installed between RS+ and RS- current-sensing
> +inputs.
>
next prev parent reply other threads:[~2017-04-02 9:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 15:12 [PATCH v4 0/4] iio: adc: Maxim max9611 driver Jacopo Mondi
2017-03-27 15:12 ` Jacopo Mondi
2017-03-27 15:12 ` [PATCH v4 1/4] Documentation: dt-bindings: iio: Add max9611 ADC Jacopo Mondi
2017-03-27 15:12 ` Jacopo Mondi
2017-04-02 9:35 ` Jonathan Cameron [this message]
2017-04-03 13:26 ` Rob Herring
2017-03-27 15:12 ` [PATCH v4 2/4] iio: Documentation: Add max9611 sysfs documentation Jacopo Mondi
2017-03-27 15:12 ` Jacopo Mondi
2017-04-02 9:36 ` Jonathan Cameron
2017-04-02 9:53 ` Jonathan Cameron
2017-03-27 15:12 ` [PATCH v4 3/4] iio: adc: Add Maxim max9611 ADC driver Jacopo Mondi
2017-03-27 15:12 ` Jacopo Mondi
2017-04-02 9:43 ` Jonathan Cameron
2017-04-02 9:43 ` Jonathan Cameron
2017-03-27 15:12 ` [PATCH v4 4/4] arm64: dts: salvator-x: Add current sense amplifiers Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeffe49b-7f70-0cad-88c4-76b3e5807b7b@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=jacopo+renesas@jmondi.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.