From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
sound-open-firmware@alsa-project.org
Cc: broonie@kernel.org, ranjani.sridharan@linux.intel.com,
pierre-louis.bossart@linux.intel.com, rander.wang@intel.com
Subject: Re: [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
Date: Thu, 18 Aug 2022 11:14:41 +0300 [thread overview]
Message-ID: <afcaffc6-aa07-d95f-6823-a858b53ee978@linux.intel.com> (raw)
In-Reply-To: <20220818081751.2407066-1-yangyingliang@huawei.com>
On 18/08/2022 11:17, Yang Yingliang wrote:
> It should be size of the struct sof_ipc4_src, not data pointer pass to
> sof_update_ipc_object().
Good find, thank you.
Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> sound/soc/sof/ipc4-topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
> index af072b484a60..c6abfaf5d532 100644
> --- a/sound/soc/sof/ipc4-topology.c
> +++ b/sound/soc/sof/ipc4-topology.c
> @@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget)
> goto err;
>
> ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples,
> - swidget->num_tuples, sizeof(src), 1);
> + swidget->num_tuples, sizeof(*src), 1);
> if (ret) {
> dev_err(scomp->dev, "Parsing SRC tokens failed\n");
> goto err;
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
sound-open-firmware@alsa-project.org
Cc: rander.wang@intel.com, pierre-louis.bossart@linux.intel.com,
ranjani.sridharan@linux.intel.com, broonie@kernel.org
Subject: Re: [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
Date: Thu, 18 Aug 2022 11:14:41 +0300 [thread overview]
Message-ID: <afcaffc6-aa07-d95f-6823-a858b53ee978@linux.intel.com> (raw)
In-Reply-To: <20220818081751.2407066-1-yangyingliang@huawei.com>
On 18/08/2022 11:17, Yang Yingliang wrote:
> It should be size of the struct sof_ipc4_src, not data pointer pass to
> sof_update_ipc_object().
Good find, thank you.
Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> sound/soc/sof/ipc4-topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
> index af072b484a60..c6abfaf5d532 100644
> --- a/sound/soc/sof/ipc4-topology.c
> +++ b/sound/soc/sof/ipc4-topology.c
> @@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget)
> goto err;
>
> ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples,
> - swidget->num_tuples, sizeof(src), 1);
> + swidget->num_tuples, sizeof(*src), 1);
> if (ret) {
> dev_err(scomp->dev, "Parsing SRC tokens failed\n");
> goto err;
--
Péter
next prev parent reply other threads:[~2022-08-18 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 8:17 [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src() Yang Yingliang
2022-08-18 8:17 ` Yang Yingliang
2022-08-18 8:14 ` Péter Ujfalusi [this message]
2022-08-18 8:14 ` Péter Ujfalusi
2022-08-18 15:11 ` Mark Brown
2022-08-18 15:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afcaffc6-aa07-d95f-6823-a858b53ee978@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.