From: Nicolin Chen <nicolinc@nvidia.com>
To: Shameer Kolothum <skolothumtho@nvidia.com>
Cc: <qemu-arm@nongnu.org>, <qemu-devel@nongnu.org>,
<eric.auger@redhat.com>, <peter.maydell@linaro.org>,
<clg@redhat.com>, <alex@shazbot.org>, <nathanc@nvidia.com>,
<mochs@nvidia.com>, <jan@nvidia.com>, <jgg@nvidia.com>,
<jonathan.cameron@huawei.com>, <zhenzhong.duan@intel.com>,
<kjaju@nvidia.com>, <phrdina@redhat.com>
Subject: Re: [PATCH v4 23/31] hw/arm/smmuv3-accel: Introduce common helper for veventq read
Date: Mon, 4 May 2026 18:07:06 -0700 [thread overview]
Message-ID: <aflCuvleKMiVsvY2@nvidia.com> (raw)
In-Reply-To: <20260415105552.622421-24-skolothumtho@nvidia.com>
On Wed, Apr 15, 2026 at 11:55:44AM +0100, Shameer Kolothum wrote:
> Move the vEVENTQ read and validation logic into a common helper
> smmuv3_accel_event_read_validate(). The helper performs the read(),
> checks for overflow and short reads, validates the sequence number,
> and updates the sequence state.
>
> This helper can be reused for Tegra241 CMDQV vEVENTQ support in a
> subsequent patch.
>
> Error handling is slightly adjusted: instead of reporting errors
> directly in the read handler, the helper now returns errors via
> Error **. Sequence gaps are reported as warnings.
>
> Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
next prev parent reply other threads:[~2026-05-05 1:08 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 10:55 [PATCH v4 00/31] hw/arm/virt: Introduce Tegra241 CMDQV support for accelerated SMMUv3 Shameer Kolothum
2026-04-15 10:55 ` [PATCH v4 01/31] backends/iommufd: Update iommufd_backend_get_device_info Shameer Kolothum
2026-04-15 10:55 ` [PATCH v4 02/31] backends/iommufd: Update iommufd_backend_alloc_viommu to allow user ptr Shameer Kolothum
2026-04-15 10:55 ` [PATCH v4 03/31] backends/iommufd: Introduce iommufd_backend_alloc_hw_queue Shameer Kolothum
2026-04-15 10:55 ` [PATCH v4 04/31] backends/iommufd: Introduce iommufd_backend_viommu_mmap Shameer Kolothum
2026-04-15 10:55 ` [PATCH v4 05/31] system/iommufd: Remove unused viommu pointer from IOMMUFDVeventq Shameer Kolothum
2026-05-04 15:00 ` Eric Auger
2026-05-04 18:16 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 06/31] hw/arm/smmuv3-accel: Introduce CMDQV ops interface Shameer Kolothum
2026-05-04 15:19 ` Eric Auger
2026-05-04 18:28 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 07/31] hw/arm/tegra241-cmdqv: Add Tegra241 CMDQV ops backend stub Shameer Kolothum
2026-05-04 15:19 ` Eric Auger
2026-05-04 18:23 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 08/31] hw/arm/smmuv3-accel: Wire CMDQV ops into accel lifecycle Shameer Kolothum
2026-05-04 15:33 ` Eric Auger
2026-05-05 7:47 ` Shameer Kolothum Thodi
2026-05-04 18:38 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 09/31] hw/arm/virt: Use stored SMMUv3 device list for IORT build Shameer Kolothum
2026-05-04 18:46 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 10/31] hw/arm/tegra241-cmdqv: Probe host Tegra241 CMDQV support Shameer Kolothum
2026-05-04 18:49 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 11/31] hw/arm/tegra241-cmdqv: Implement CMDQV init Shameer Kolothum
2026-04-15 10:55 ` [PATCH v4 12/31] hw/arm/virt: Link SMMUv3 CMDQV resources to platform bus Shameer Kolothum
2026-05-04 18:57 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 13/31] hw/arm/tegra241-cmdqv: Implement CMDQV vIOMMU alloc/free Shameer Kolothum
2026-05-04 16:01 ` Eric Auger
2026-05-04 19:54 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 14/31] hw/arm/tegra241-cmdqv: Emulate CMDQ-V Config region Shameer Kolothum
2026-05-05 0:09 ` Nicolin Chen
2026-05-05 7:26 ` Eric Auger
2026-05-05 10:28 ` Shameer Kolothum Thodi
2026-04-15 10:55 ` [PATCH v4 15/31] hw/arm/tegra241-cmdqv: Emulate VCMDQ register reads Shameer Kolothum
2026-05-05 10:12 ` Eric Auger
2026-05-05 13:27 ` Shameer Kolothum Thodi
2026-05-06 11:14 ` Eric Auger
2026-04-15 10:55 ` [PATCH v4 16/31] hw/arm/tegra241-cmdqv: Emulate VCMDQ register writes Shameer Kolothum
2026-05-05 10:42 ` Eric Auger
2026-05-05 13:49 ` Shameer Kolothum Thodi
2026-04-15 10:55 ` [PATCH v4 17/31] hw/arm/tegra241-cmdqv: mmap VINTF Page0 for CMDQV Shameer Kolothum
2026-04-15 10:55 ` [PATCH v4 18/31] system/physmem: Add address_space_is_ram() helper Shameer Kolothum
2026-05-05 0:24 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 19/31] hw/arm/tegra241-cmdqv: Allocate HW VCMDQs on base register programming Shameer Kolothum
2026-05-05 0:40 ` Nicolin Chen
2026-05-05 9:59 ` Shameer Kolothum Thodi
2026-05-05 19:38 ` Nicolin Chen
2026-05-06 8:18 ` Shameer Kolothum Thodi
2026-05-06 18:18 ` Nicolin Chen
2026-05-05 13:25 ` Eric Auger
2026-05-05 14:26 ` Shameer Kolothum Thodi
2026-05-06 17:49 ` Nicolin Chen
2026-05-08 14:50 ` Eric Auger
2026-05-06 16:51 ` Eric Auger
2026-05-06 18:21 ` Nicolin Chen via
2026-05-06 18:21 ` Nicolin Chen via qemu development
2026-04-15 10:55 ` [PATCH v4 20/31] hw/arm/tegra241-cmdqv: Use mmap'd VINTF page0 as VCMDQ backing Shameer Kolothum
2026-05-05 0:50 ` Nicolin Chen
2026-05-05 15:13 ` Shameer Kolothum Thodi
2026-05-05 19:52 ` Nicolin Chen
2026-05-06 13:16 ` Shameer Kolothum Thodi
2026-05-06 18:34 ` Nicolin Chen
2026-05-06 20:13 ` Shameer Kolothum Thodi
2026-05-06 20:55 ` Nicolin Chen
2026-05-06 12:27 ` Eric Auger
2026-04-15 10:55 ` [PATCH v4 21/31] memory: Allow RAM device regions to skip IOMMU mapping Shameer Kolothum
2026-05-06 12:39 ` Eric Auger
2026-04-15 10:55 ` [PATCH v4 22/31] hw/arm/tegra241-cmdqv: Map VINTF page0 into guest MMIO space Shameer Kolothum
2026-05-06 12:44 ` Eric Auger
2026-05-06 14:24 ` Shameer Kolothum Thodi
2026-05-07 16:24 ` Eric Auger
2026-05-08 9:03 ` Shameer Kolothum Thodi
2026-05-08 14:35 ` Eric Auger
2026-05-08 14:37 ` Shameer Kolothum Thodi
2026-04-15 10:55 ` [PATCH v4 23/31] hw/arm/smmuv3-accel: Introduce common helper for veventq read Shameer Kolothum
2026-05-05 1:07 ` Nicolin Chen [this message]
2026-05-06 12:49 ` Eric Auger
2026-04-15 10:55 ` [PATCH v4 24/31] hw/arm/tegra241-cmdqv: Read and propagate Tegra241 CMDQV errors Shameer Kolothum
2026-05-05 1:13 ` Nicolin Chen
2026-05-07 16:40 ` Eric Auger
2026-05-08 10:52 ` Shameer Kolothum Thodi
2026-04-15 10:55 ` [PATCH v4 25/31] hw/arm/tegra241-cmdqv: Add reset handler Shameer Kolothum
2026-05-07 16:51 ` Eric Auger
2026-05-08 11:19 ` Shameer Kolothum Thodi
2026-05-08 14:39 ` Eric Auger
2026-05-07 17:03 ` Eric Auger
2026-04-15 10:55 ` [PATCH v4 26/31] hw/arm/tegra241-cmdqv: Limit queue size based on backend page size Shameer Kolothum
2026-05-05 1:26 ` Nicolin Chen
2026-05-07 17:23 ` Eric Auger
2026-05-08 13:38 ` Shameer Kolothum Thodi
2026-05-08 14:41 ` Eric Auger
2026-04-15 10:55 ` [PATCH v4 27/31] hw/arm/smmuv3: Add per-device identifier property Shameer Kolothum
2026-05-05 1:30 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 28/31] hw/arm/smmuv3-accel: Introduce helper to query CMDQV type Shameer Kolothum
2026-05-05 1:32 ` Nicolin Chen
2026-04-15 10:55 ` [PATCH v4 29/31] hw/arm/virt-acpi: Advertise Tegra241 CMDQV nodes in DSDT Shameer Kolothum
2026-05-07 17:32 ` Eric Auger
2026-04-15 10:55 ` [PATCH v4 30/31] hw/arm/smmuv3-accel: Enforce viommu association when CMDQV is active Shameer Kolothum
2026-05-05 1:35 ` Nicolin Chen
2026-05-07 17:36 ` Eric Auger
2026-05-08 14:36 ` Shameer Kolothum Thodi
2026-04-15 10:55 ` [PATCH v4 31/31] hw/arm/smmuv3: Add cmdqv property for SMMUv3 device Shameer Kolothum
2026-05-07 17:28 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aflCuvleKMiVsvY2@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=alex@shazbot.org \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jan@nvidia.com \
--cc=jgg@nvidia.com \
--cc=jonathan.cameron@huawei.com \
--cc=kjaju@nvidia.com \
--cc=mochs@nvidia.com \
--cc=nathanc@nvidia.com \
--cc=peter.maydell@linaro.org \
--cc=phrdina@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=skolothumtho@nvidia.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.