[PATCH linux dev-6.18] eeprom: ee1004: Fix build error

[PATCH linux dev-6.18] eeprom: ee1004: Fix build error

[Konstantin Aladyshev]

Currently driver compilation fails because of the undeclared
'ee1004_groups' variable.
This variable was deleted in the commit
79d0df36b541 ("eeprom: ee1004: Add nvmem support")
but by mistake was used in the commit
1b9ab93850ac ("eeprom: ee1004: Add OF matching support").
Remove 'ee1004_groups' usage from the driver to fix the compilation.

Fixes: 79d0df36b541 ("eeprom: ee1004: Add nvmem support")

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 drivers/misc/eeprom/ee1004.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/misc/eeprom/ee1004.c b/drivers/misc/eeprom/ee1004.c
index 639615749e2f..e1a571b77de9 100644
--- a/drivers/misc/eeprom/ee1004.c
+++ b/drivers/misc/eeprom/ee1004.c
@@ -347,7 +347,6 @@ static int ee1004_probe(struct i2c_client *client)
 static struct i2c_driver ee1004_driver = {
 	.driver = {
 		.name = "ee1004",
-		.dev_groups = ee1004_groups,
 		.of_match_table = ee1004_of_match,
 	},
 	.probe = ee1004_probe,
-- 
2.43.0

[PATCH linux dev-6.18 v2] eeprom: ee1004: Fix build error

[Konstantin Aladyshev]

Currently driver compilation fails because of the undeclared
'ee1004_groups' variable.
This variable was deleted in the commit
79d0df36b541 ("eeprom: ee1004: Add nvmem support")
but by mistake was used in the commit
1b9ab93850ac ("eeprom: ee1004: Add OF matching support").
Remove 'ee1004_groups' usage from the driver to fix the compilation.

Fixes: 1b9ab93850ac ("eeprom: ee1004: Add OF matching support")

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 drivers/misc/eeprom/ee1004.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/misc/eeprom/ee1004.c b/drivers/misc/eeprom/ee1004.c
index 639615749e2f..e1a571b77de9 100644
--- a/drivers/misc/eeprom/ee1004.c
+++ b/drivers/misc/eeprom/ee1004.c
@@ -347,7 +347,6 @@ static int ee1004_probe(struct i2c_client *client)
 static struct i2c_driver ee1004_driver = {
 	.driver = {
 		.name = "ee1004",
-		.dev_groups = ee1004_groups,
 		.of_match_table = ee1004_of_match,
 	},
 	.probe = ee1004_probe,
-- 
2.43.0

Re: [PATCH linux dev-6.18] eeprom: ee1004: Fix build error

[Johannes Truschnigg]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Wed, Apr 29, 2026 at 10:06:47AM +0300, Konstantin Aladyshev wrote:
> Currently driver compilation fails because of the undeclared
> 'ee1004_groups' variable.
> [...]
> Fixes: 79d0df36b541 ("eeprom: ee1004: Add nvmem support")

Ftr, this patch on (top of 80ec78d (6.18.26)) fixes building linux-aspeed with
CONFIG_EEPROM_EE1004=y configured for me, which has otherwise been broken
since around October 2025.

I recommend merging it :)

-- 
with best regards:
- Johannes Truschnigg ( johannes@truschnigg.info )

www:   https://johannes.truschnigg.info/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH linux dev-6.18] eeprom: ee1004: Fix build error

[Tan Siewert]

On 5/6/26 8:52 AM, Johannes Truschnigg wrote:
> On Wed, Apr 29, 2026 at 10:06:47AM +0300, Konstantin Aladyshev wrote:
>> Currently driver compilation fails because of the undeclared
>> 'ee1004_groups' variable.
>> [...]
>> Fixes: 79d0df36b541 ("eeprom: ee1004: Add nvmem support")
> 
> Ftr, this patch on (top of 80ec78d (6.18.26)) fixes building linux-aspeed with
> CONFIG_EEPROM_EE1004=y configured for me, which has otherwise been broken
> since around October 2025.
> 
> I recommend merging it :)
> 

It'd be great if the patch could be sent to LKML and let it be 
backported to the upstream 6.18 LTS tree instead of having it only in 
the OpenBMC tree.

To cite the kernel development doc [0]:
"Submit your patch upstream. It doesn't need to be upstream, but it 
should be on it's way, and not have any unresolved design concerns."

[0] 
https://github.com/openbmc/docs/blob/92b89c6ac71f8b94f67f508102704a1cf38e68cb/kernel-development.md?plain=1#L29

	Tan

Re: [PATCH linux dev-6.18] eeprom: ee1004: Fix build error

[Konstantin Aladyshev]

I think this is specifically an OpenBMC kernel problem.
I don't see this error neither in upstream Linux master
https://github.com/torvalds/linux/blob/master/drivers/misc/eeprom/ee1004.c#L341
nor in Linux 6.18
https://github.com/torvalds/linux/blob/v6.18/drivers/misc/eeprom/ee1004.c#L341

On Wed, May 6, 2026 at 6:30 PM Tan Siewert <tan.siewert@9elements.com> wrote:
>
> On 5/6/26 8:52 AM, Johannes Truschnigg wrote:
> > On Wed, Apr 29, 2026 at 10:06:47AM +0300, Konstantin Aladyshev wrote:
> >> Currently driver compilation fails because of the undeclared
> >> 'ee1004_groups' variable.
> >> [...]
> >> Fixes: 79d0df36b541 ("eeprom: ee1004: Add nvmem support")
> >
> > Ftr, this patch on (top of 80ec78d (6.18.26)) fixes building linux-aspeed with
> > CONFIG_EEPROM_EE1004=y configured for me, which has otherwise been broken
> > since around October 2025.
> >
> > I recommend merging it :)
> >
>
> It'd be great if the patch could be sent to LKML and let it be
> backported to the upstream 6.18 LTS tree instead of having it only in
> the OpenBMC tree.
>
> To cite the kernel development doc [0]:
> "Submit your patch upstream. It doesn't need to be upstream, but it
> should be on it's way, and not have any unresolved design concerns."
>
> [0]
> https://github.com/openbmc/docs/blob/92b89c6ac71f8b94f67f508102704a1cf38e68cb/kernel-development.md?plain=1#L29
>
>         Tan

Re: [PATCH linux dev-6.18] eeprom: ee1004: Fix build error

[Andrew Jeffery]

On Wed, 2026-04-29 at 10:06 +0300, Konstantin Aladyshev wrote:
> Currently driver compilation fails because of the undeclared
> 'ee1004_groups' variable.
> This variable was deleted in the commit
> 79d0df36b541 ("eeprom: ee1004: Add nvmem support")
> but by mistake was used in the commit
> 1b9ab93850ac ("eeprom: ee1004: Add OF matching support").
> Remove 'ee1004_groups' usage from the driver to fix the compilation.
> 
> Fixes: 79d0df36b541 ("eeprom: ee1004: Add nvmem support")
> 
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

Applied, thanks.

Sorry for the delay.

Andrew