From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Tianshu Qiu <tian.shu.qiu@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
David Heidelberg <david@ixit.cz>,
20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz
Subject: Re: [PATCH 07/13] media: imx355: Remove link_freq_index from each mode as ununsed
Date: Thu, 7 May 2026 16:12:44 +0200 [thread overview]
Message-ID: <afyd08he6apxpVYA@zed> (raw)
In-Reply-To: <20260506-media-imx355-v1-7-660685030455@raspberrypi.com>
Hi Dave
On Wed, May 06, 2026 at 07:23:45PM +0100, Dave Stevenson wrote:
> The link_freq_index value in imx355_mode is unused, so remove it.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
> drivers/media/i2c/imx355.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index 422454e529a7..b0cddb614775 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -82,7 +82,6 @@
>
> /* default link frequency and external clock */
> #define IMX355_LINK_FREQ_DEFAULT 360000000LL
> -#define IMX355_LINK_FREQ_INDEX 0
>
> /* number of data lanes */
> #define IMX355_DATA_LANES 4
> @@ -111,9 +110,6 @@ struct imx355_mode {
> /* H-timing */
> u32 llp;
>
> - /* index of link frequency */
> - u32 link_freq_index;
> -
> /* Default register values */
> struct imx355_reg_list reg_list;
>
> @@ -367,7 +363,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 2615,
> .fll_min = 2615,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_3280x2464_regs),
> .regs = mode_3280x2464_regs,
> @@ -384,7 +379,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 2615,
> .fll_min = 2615,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_3268x2448_regs),
> .regs = mode_3268x2448_regs,
> @@ -401,7 +395,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 2615,
> .fll_min = 2615,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_3264x2448_regs),
> .regs = mode_3264x2448_regs,
> @@ -418,7 +411,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1940x1096_regs),
> .regs = mode_1940x1096_regs,
> @@ -435,7 +427,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1936x1096_regs),
> .regs = mode_1936x1096_regs,
> @@ -452,7 +443,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1924x1080_regs),
> .regs = mode_1924x1080_regs,
> @@ -469,7 +459,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1920x1080_regs),
> .regs = mode_1920x1080_regs,
> @@ -486,7 +475,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1640x1232_regs),
> .regs = mode_1640x1232_regs,
> @@ -503,7 +491,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1640x922_regs),
> .regs = mode_1640x922_regs,
> @@ -520,7 +507,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1300x736_regs),
> .regs = mode_1300x736_regs,
> @@ -537,7 +523,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1296x736_regs),
> .regs = mode_1296x736_regs,
> @@ -554,7 +539,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1284x720_regs),
> .regs = mode_1284x720_regs,
> @@ -571,7 +555,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1280x720_regs),
> .regs = mode_1280x720_regs,
> @@ -588,7 +571,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 652,
> .fll_min = 652,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_820x616_regs),
> .regs = mode_820x616_regs,
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2026-05-07 14:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 18:23 [PATCH 00/13] media/imx355: General code cleanups, and adding support for 2 lane operation Dave Stevenson
2026-05-06 18:23 ` [PATCH 01/13] media: imx355: Remove duplicated registers from the mode tables Dave Stevenson
2026-05-07 13:41 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 02/13] media: imx355: Remove setting FRM_LENGTH_LINES in the mode regs Dave Stevenson
2026-05-07 13:50 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 03/13] media: imx355: Programmatically set the crop parameters for each mode Dave Stevenson
2026-05-07 14:00 ` Jacopo Mondi
2026-05-07 16:01 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 04/13] media: imx355: Remove the duplication between width/height and x/y_out_size Dave Stevenson
2026-05-06 18:23 ` [PATCH 05/13] media: imx355: Set register LINE_LENGTH_PCK programmatically Dave Stevenson
2026-05-07 14:09 ` Jacopo Mondi
2026-05-07 15:18 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 06/13] media: imx355: Set binning mode registers programmatically Dave Stevenson
2026-05-07 14:12 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 07/13] media: imx355: Remove link_freq_index from each mode as ununsed Dave Stevenson
2026-05-07 14:12 ` Jacopo Mondi [this message]
2026-05-06 18:23 ` [PATCH 08/13] media: imx355: pixel_rate never changes, so don't recompute Dave Stevenson
2026-05-07 14:13 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 09/13] media: imx355: Remove redundant fll_min, and implement fixed offset Dave Stevenson
2026-05-07 14:29 ` Jacopo Mondi
2026-05-07 15:21 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 10/13] media: imx355: Add support for get_selection Dave Stevenson
2026-05-07 14:42 ` Jacopo Mondi
2026-05-07 15:02 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 11/13] media: imx355: Use pm_runtime autosuspend_delay Dave Stevenson
2026-05-07 14:43 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 12/13] media: imx355: Convert to new CCI register access helpers Dave Stevenson
2026-05-07 14:49 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 13/13] media: imx355: Support 2 lane readout Dave Stevenson
2026-05-13 18:33 ` Richard Acayan
2026-05-14 10:37 ` Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afyd08he6apxpVYA@zed \
--to=jacopo.mondi@ideasonboard.com \
--cc=20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz \
--cc=dave.stevenson@raspberrypi.com \
--cc=david@ixit.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.