Re: [PATCH] drm/xe: Fix return type of disable_late_binding_set() in debugfs

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, May 20, 2026 at 12:32:55PM +0530, Mohanram Meenakshisundaram wrote:
> Fix disable_late_binding_set() to declare 'ret' as ssize_t instead of
> int, consistent with the function's return type.
> 
> Also remove '0' initializations for the 'len' variable in

If you do both in the same patch, please adjust the subject/title
line to something like:

drm/xe: Adjust variable initialization in xe_debugfs.c

or something like that that is generic enough.

> four debugfs show functions (wedged_mode_show,
> atomic_svm_timeslice_ms_show,
> min_run_period_lr_ms_show, min_run_period_pf_ms_show).
> The variable is updated immediately on next line by scnprintf(), so the
> initialize to '0' not required.
> 
> Fixes: 62519b77aeca ("drm/xe: Fix memory leak when handling pagefault vma")

I can't see how this commit 62519b77aeca has anything to do with this patch
here....
Please provide a proper fix or simply remove it.

> Signed-off-by: Mohanram Meenakshisundaram <mohanram.meenakshisundaram@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_debugfs.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
> index 22b471303984..675cc0ddd83b 100644
> --- a/drivers/gpu/drm/xe/xe_debugfs.c
> +++ b/drivers/gpu/drm/xe/xe_debugfs.c
> @@ -282,7 +282,7 @@ static ssize_t wedged_mode_show(struct file *f, char __user *ubuf,
>  {
>  	struct xe_device *xe = file_inode(f)->i_private;
>  	char buf[32];
> -	int len = 0;
> +	int len;
>  
>  	len = scnprintf(buf, sizeof(buf), "%d\n", xe->wedged.mode);
>  
> @@ -411,7 +411,7 @@ static ssize_t atomic_svm_timeslice_ms_show(struct file *f, char __user *ubuf,
>  {
>  	struct xe_device *xe = file_inode(f)->i_private;
>  	char buf[32];
> -	int len = 0;
> +	int len;
>  
>  	len = scnprintf(buf, sizeof(buf), "%d\n", xe->atomic_svm_timeslice_ms);
>  
> @@ -446,7 +446,7 @@ static ssize_t min_run_period_lr_ms_show(struct file *f, char __user *ubuf,
>  {
>  	struct xe_device *xe = file_inode(f)->i_private;
>  	char buf[32];
> -	int len = 0;
> +	int len;
>  
>  	len = scnprintf(buf, sizeof(buf), "%d\n", xe->min_run_period_lr_ms);
>  
> @@ -480,7 +480,7 @@ static ssize_t min_run_period_pf_ms_show(struct file *f, char __user *ubuf,
>  {
>  	struct xe_device *xe = file_inode(f)->i_private;
>  	char buf[32];
> -	int len = 0;
> +	int len;
>  
>  	len = scnprintf(buf, sizeof(buf), "%d\n", xe->min_run_period_pf_ms);
>  
> @@ -528,7 +528,7 @@ static ssize_t disable_late_binding_set(struct file *f, const char __user *ubuf,
>  	struct xe_device *xe = file_inode(f)->i_private;
>  	struct xe_late_bind *late_bind = &xe->late_bind;
>  	bool val;
> -	int ret;
> +	ssize_t ret;
>  
>  	ret = kstrtobool_from_user(ubuf, size, &val);
>  	if (ret)
> -- 
> 2.34.1
>