All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Fix return type of disable_late_binding_set() in debugfs
@ 2026-05-20  7:02 Mohanram Meenakshisundaram
  2026-05-20  7:16 ` ✓ CI.KUnit: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 13+ messages in thread
From: Mohanram Meenakshisundaram @ 2026-05-20  7:02 UTC (permalink / raw)
  To: intel-xe, matthew.brost, rodrigo.vivi; +Cc: Mohanram Meenakshisundaram

Fix disable_late_binding_set() to declare 'ret' as ssize_t instead of
int, consistent with the function's return type.

Also remove '0' initializations for the 'len' variable in
four debugfs show functions (wedged_mode_show,
atomic_svm_timeslice_ms_show,
min_run_period_lr_ms_show, min_run_period_pf_ms_show).
The variable is updated immediately on next line by scnprintf(), so the
initialize to '0' not required.

Fixes: 62519b77aeca ("drm/xe: Fix memory leak when handling pagefault vma")
Signed-off-by: Mohanram Meenakshisundaram <mohanram.meenakshisundaram@intel.com>
---
 drivers/gpu/drm/xe/xe_debugfs.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
index 22b471303984..675cc0ddd83b 100644
--- a/drivers/gpu/drm/xe/xe_debugfs.c
+++ b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -282,7 +282,7 @@ static ssize_t wedged_mode_show(struct file *f, char __user *ubuf,
 {
 	struct xe_device *xe = file_inode(f)->i_private;
 	char buf[32];
-	int len = 0;
+	int len;
 
 	len = scnprintf(buf, sizeof(buf), "%d\n", xe->wedged.mode);
 
@@ -411,7 +411,7 @@ static ssize_t atomic_svm_timeslice_ms_show(struct file *f, char __user *ubuf,
 {
 	struct xe_device *xe = file_inode(f)->i_private;
 	char buf[32];
-	int len = 0;
+	int len;
 
 	len = scnprintf(buf, sizeof(buf), "%d\n", xe->atomic_svm_timeslice_ms);
 
@@ -446,7 +446,7 @@ static ssize_t min_run_period_lr_ms_show(struct file *f, char __user *ubuf,
 {
 	struct xe_device *xe = file_inode(f)->i_private;
 	char buf[32];
-	int len = 0;
+	int len;
 
 	len = scnprintf(buf, sizeof(buf), "%d\n", xe->min_run_period_lr_ms);
 
@@ -480,7 +480,7 @@ static ssize_t min_run_period_pf_ms_show(struct file *f, char __user *ubuf,
 {
 	struct xe_device *xe = file_inode(f)->i_private;
 	char buf[32];
-	int len = 0;
+	int len;
 
 	len = scnprintf(buf, sizeof(buf), "%d\n", xe->min_run_period_pf_ms);
 
@@ -528,7 +528,7 @@ static ssize_t disable_late_binding_set(struct file *f, const char __user *ubuf,
 	struct xe_device *xe = file_inode(f)->i_private;
 	struct xe_late_bind *late_bind = &xe->late_bind;
 	bool val;
-	int ret;
+	ssize_t ret;
 
 	ret = kstrtobool_from_user(ubuf, size, &val);
 	if (ret)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2026-05-25  6:17 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-20  7:02 [PATCH] drm/xe: Fix return type of disable_late_binding_set() in debugfs Mohanram Meenakshisundaram
2026-05-20  7:16 ` ✓ CI.KUnit: success for " Patchwork
2026-05-20  7:56 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-20 15:34 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-20 19:16 ` [PATCH] " Rodrigo Vivi
2026-05-21  6:09 ` [PATCH v2 0/2] drm/xe: Fix return type and adjust variable Mohanram Meenakshisundaram
2026-05-21  6:09   ` [PATCH v2 1/2] drm/xe: Fix return type of disable_late_binding_set() in debugfs Mohanram Meenakshisundaram
2026-05-21 12:09     ` Michal Wajdeczko
2026-05-25  6:11     ` Mohanram Meenakshisundaram
2026-05-21  6:09   ` [PATCH v2 2/2] drm/xe: Adjust variable initialization in xe_debugfs Mohanram Meenakshisundaram
2026-05-21  6:55 ` ✓ CI.KUnit: success for drm/xe: Fix return type of disable_late_binding_set() in debugfs (rev2) Patchwork
2026-05-21  7:48 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-21  9:44 ` ✗ Xe.CI.FULL: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.