Re: [PATCH v6 0/4] platform/x86: hp-wmi: Add Victus 15-fb0xxx fan control

[Krishna Chomal <krishna.chomal108@gmail.com>]

Hi all,

Apologies, I accidentally replied to the v5 cover letter right as v6
was published. Re-posting my feedback here for the correct thread:

On Thu, May 21, 2026 at 07:03:47PM +0530, Radhey Kalra wrote:
>Hi,
>
>This is a split version of the Victus 15-fb0xxx fan-control change.
>Patches 1 and 2 are no-functional-changes-intended refactors which move
>the existing thermal-profile and fan-control decisions into
>board-specific .driver_data. Patch 3 fixes the fan-table GPU delta
>parsing issue found while testing this board. Patch 4 adds fan-control
>support for Victus 15-fb0xxx board 8A3D.
>
>v6 splits the gpu_delta fan-table parsing fix back into its own patch.
>The previous 2-patch v5 folded that behavioral parser fix into the board
>data preparation patch, which was a mistake.
>
>8A3D is kept fan-control-only because the verified behavior is the
>Victus fan-control path. The existing generic platform-profile sysfs path
>on 8A3D accepts writes/readbacks without hp_wmi errors, but CPU/GPU
>power-policy behavior was not meaningfully validated.

You are right. Because your board is not registered in any list, so it
goes to a fallback route and registers quiet/balanced/performance/cool.
Changes to platform profile are handled through this chain:

hp_wmi_platform_profile_set
	-> thermal_profile_set
		-> hp_wmi_perform_query(HPWMI_THERMAL_PROFILE_QUERY)

For my device, when I selected victus_8a3d_board_params quirk, the driver
tried to use this query HPWMI_THERMAL_PROFILE_QUERY which failed and
caused the driver to not load. In you case, it looks like the query does
not return an error. However, not returning an error does not necessarily
imply that it is working correctly, which can be further confirmed when
you mention that changing power modes has no physical effect on the system.

>Adding 8A3D to the Victus S thermal-profile table would move it to a
>different, Victus S-specific platform-profile path that has not been
>verified on this board.

I apologise if this comes off as pestering, but I do feel that Victus-S
path should be tested at least once. I may be wrong, but at least we
would come to know that it is not the right approach.

>Based on platform-drivers-x86/for-next commit:
>165e81354eefd5551358112773f24027aac59d5a
>
>Tested on a Victus by HP Gaming Laptop 15-fb0xxx, board 8A3D, BIOS
>F.22. With the series applied, pwm1 and pwm1_enable are exposed and
>the EC-layout warning is not emitted for 8A3D.
>
>Radhey Kalra (4):
>  platform/x86: hp-wmi: Introduce board-specific feature data
>  platform/x86: hp-wmi: Drive fan control from board data
>  platform/x86: hp-wmi: Skip zero GPU RPM rows for fan speed delta
>  platform/x86: hp-wmi: Add Victus 15-fb0xxx fan control
>
> drivers/platform/x86/hp/hp-wmi.c | 212 ++++++++++++++++++++++---------
> 1 file changed, 153 insertions(+), 59 deletions(-)
>
>---
>Changes in v6:
>- Split the gpu_delta fan-table parser fix back out into its own patch.
>- Keep 8A3D fan-control-only and document why the Victus S
>  platform-profile path is not enabled for this board.
>
>Changes in v5:
>- Drop the active_thermal_profile_params global and dereference the
>  thermal-profile data through active_board_params.
>- Move the generic fan-only board handling into patch 1, keeping the
>  final 8A3D patch focused on adding the board data and DMI match.
>- Wrap the setup comment added in patch 1 to stay under 80 columns.
>
>Changes in v4:
>- Split v3 into two no-functional-changes-intended refactors, one
>  fan-table parsing fix, and one 8A3D support patch.
>- Rebase on platform-drivers-x86/for-next commit 165e81354eefd555.
>- Move revision notes to the cover letter.
>
>Changes in v3:
>- Rebase on platform-drivers-x86/for-next commit 165e81354eefd555.
>- Keep the v2 board-data approach and 8A3D fan-control-only handling.
>
>Changes in v2:
>- Use real name in Signed-off-by.
>- Replace the ad-hoc fan-control DMI table with board data in
>  .driver_data.
>- Keep 8A3D fan-control-only instead of enabling Victus S thermal
>  profiles.
>- Use the fixed fan-table parser path and derive gpu_delta from the
>  first non-zero GPU row.
>
>-- 
>2.54.0