Re: [PATCH v6 3/4] platform/x86: hp-wmi: Skip zero GPU RPM rows for fan speed delta

[Krishna Chomal <krishna.chomal108@gmail.com>]

On Fri, May 22, 2026 at 04:56:02PM +0300, Ilpo Järvinen wrote:
>On Thu, 21 May 2026, Krishna Chomal wrote:
>
>> On Thu, May 21, 2026 at 07:03:50PM +0530, Radhey Kalra wrote:
>> > Some Victus fan tables start with a CPU RPM value while the GPU RPM
>> > field is zero. On board 8A3D the first row is cpu=23, gpu=0, noise=25,
>> > followed by cpu=24, gpu=22, noise=26.
>> >
>> > Derive gpu_delta from the first row that contains a non-zero GPU RPM
>> > instead of unconditionally using row 0.
>>
>> I agree, this is essential for fan-control to work sensibly. But I just
>> want to give Ilpo Jarvinen a quick heads-up because this would likely
>> cause conflict with foobisdweik's patch [1], as they would (probably)
>> remove gpu_delta in v2 [2]
>>
>> [1]:
>> https://lore.kernel.org/platform-driver-x86/20260513193916.84673-3-dweikmferris@gmail.com
>> [2]: https://lore.kernel.org/platform-driver-x86/ag2DCOGyCt7MBUL6@archlinux
>
>Okay, so we can work on the other parts and postpone the gpu_delta part to
>that other series. It would be nice if Radhey could test with that GPU fan
>patch once the next version of it is posted.
>
>
>FYI, sashiko seems to find a few potential corner case issues unrelated to
>this series:
>
>https://sashiko.dev/#/patchset/20260521133351.1512718-1-radheykalra901%40gmail.com
>
>(Mainly to make Krishna aware of them but I certainly wouldn't mind if
>somebody else has time to tackle them). But please don't take every
>sashiko's (AI) claim as the perfect truth, it just isn't always right.

Thanks! I wasn't aware of sashiko, but I'll definitely have a deeper
look at it when I have some time.

>
>
>-- 
> i.
>