All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Pramod Maurya <pramod.nexgen@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers
Date: Sun, 10 May 2026 23:08:41 +0300	[thread overview]
Message-ID: <agDlyTzCTj2LXPVH@archlinux> (raw)
In-Reply-To: <20260510175103.562518-1-pramod.nexgen@gmail.com>

On Sun, May 10, 2026 at 01:51:01PM -0400, Pramod Maurya wrote:
> This series fixes two separate checkpatch.pl warnings in the rtl8723bs
> include headers, split into one patch per logical change:
> 
> 1. Remove superfluous consecutive blank lines from six header files.
> 2. Remove the redundant extern keyword from function prototype
>    declarations in cmd_osdep.h and fix extra whitespace in struct
>    parameter types.
> 
> v2: Split into one patch per logical change as requested by Nikolay
>     Kulikov. Added cover letter. Previous combined patch was sent as
>     "[PATCH 2/2] staging: rtl8723bs: Fix coding style in include headers".
> 
> Pramod Maurya (2):
>   staging: rtl8723bs: Remove multiple blank lines in include headers
>   staging: rtl8723bs: Remove extern from function prototypes in
>     cmd_osdep.h
> 
>  drivers/staging/rtl8723bs/include/cmd_osdep.h      | 9 ++++-----
>  drivers/staging/rtl8723bs/include/rtl8192c_recv.h  | 1 -
>  drivers/staging/rtl8723bs/include/rtl8723b_dm.h    | 1 -
>  drivers/staging/rtl8723bs/include/rtw_ioctl_set.h  | 1 -
>  drivers/staging/rtl8723bs/include/rtw_wifi_regd.h  | 1 -
>  drivers/staging/rtl8723bs/include/sdio_ops_linux.h | 1 -
>  6 files changed, 4 insertions(+), 10 deletions(-)
> 
> -- 
> 2.52.0
> 

Looks good to me.

Reviewed-by: Nikolay Kulikov <nikolayof23@gmail.com>


Thanks,
Nikolay

      parent reply	other threads:[~2026-05-10 20:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 17:51 [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Pramod Maurya
2026-05-10 17:51 ` [PATCH v2 1/2] staging: rtl8723bs: Remove multiple blank lines " Pramod Maurya
2026-05-10 17:51 ` [PATCH v2 2/2] staging: rtl8723bs: Remove extern from function prototypes in cmd_osdep.h Pramod Maurya
2026-05-11  8:09   ` Greg KH
2026-05-10 20:08 ` Nikolay Kulikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agDlyTzCTj2LXPVH@archlinux \
    --to=nikolayof23@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=pramod.nexgen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.