* [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers
@ 2026-05-10 17:51 Pramod Maurya
2026-05-10 17:51 ` [PATCH v2 1/2] staging: rtl8723bs: Remove multiple blank lines " Pramod Maurya
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Pramod Maurya @ 2026-05-10 17:51 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, nikolayof23, Pramod Maurya
This series fixes two separate checkpatch.pl warnings in the rtl8723bs
include headers, split into one patch per logical change:
1. Remove superfluous consecutive blank lines from six header files.
2. Remove the redundant extern keyword from function prototype
declarations in cmd_osdep.h and fix extra whitespace in struct
parameter types.
v2: Split into one patch per logical change as requested by Nikolay
Kulikov. Added cover letter. Previous combined patch was sent as
"[PATCH 2/2] staging: rtl8723bs: Fix coding style in include headers".
Pramod Maurya (2):
staging: rtl8723bs: Remove multiple blank lines in include headers
staging: rtl8723bs: Remove extern from function prototypes in
cmd_osdep.h
drivers/staging/rtl8723bs/include/cmd_osdep.h | 9 ++++-----
drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 1 -
drivers/staging/rtl8723bs/include/rtl8723b_dm.h | 1 -
drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 1 -
drivers/staging/rtl8723bs/include/rtw_wifi_regd.h | 1 -
drivers/staging/rtl8723bs/include/sdio_ops_linux.h | 1 -
6 files changed, 4 insertions(+), 10 deletions(-)
--
2.52.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/2] staging: rtl8723bs: Remove multiple blank lines in include headers 2026-05-10 17:51 [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Pramod Maurya @ 2026-05-10 17:51 ` Pramod Maurya 2026-05-10 17:51 ` [PATCH v2 2/2] staging: rtl8723bs: Remove extern from function prototypes in cmd_osdep.h Pramod Maurya 2026-05-10 20:08 ` [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Nikolay Kulikov 2 siblings, 0 replies; 5+ messages in thread From: Pramod Maurya @ 2026-05-10 17:51 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, nikolayof23, Pramod Maurya Remove superfluous consecutive blank lines from rtl8723bs include header files as flagged by checkpatch.pl. Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com> --- drivers/staging/rtl8723bs/include/cmd_osdep.h | 1 - drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 1 - drivers/staging/rtl8723bs/include/rtl8723b_dm.h | 1 - drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 1 - drivers/staging/rtl8723bs/include/rtw_wifi_regd.h | 1 - drivers/staging/rtl8723bs/include/sdio_ops_linux.h | 1 - 6 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/cmd_osdep.h b/drivers/staging/rtl8723bs/include/cmd_osdep.h index 5506f513dc01..41daa3c339a8 100644 --- a/drivers/staging/rtl8723bs/include/cmd_osdep.h +++ b/drivers/staging/rtl8723bs/include/cmd_osdep.h @@ -7,7 +7,6 @@ #ifndef __CMD_OSDEP_H_ #define __CMD_OSDEP_H_ - int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv); int rtw_init_evt_priv(struct evt_priv *pevtpriv); extern void _rtw_free_evt_priv(struct evt_priv *pevtpriv); diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h index e2e9aa03ffdf..1f86654f0403 100644 --- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h +++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h @@ -30,7 +30,6 @@ struct phy_stat { /* Rx smooth factor */ #define Rx_Smooth_Factor (20) - void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status); void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc); diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_dm.h b/drivers/staging/rtl8723bs/include/rtl8723b_dm.h index 1d2da5286e7c..50ab7aed079e 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_dm.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_dm.h @@ -29,5 +29,4 @@ void rtl8723b_HalDmWatchDog(struct adapter *padapter); void rtl8723b_HalDmWatchDog_in_LPS(struct adapter *padapter); void rtl8723b_hal_dm_in_lps(struct adapter *padapter); - #endif diff --git a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h index ab349de733c8..c3a1d1a84f78 100644 --- a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h +++ b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h @@ -7,7 +7,6 @@ #ifndef __RTW_IOCTL_SET_H_ #define __RTW_IOCTL_SET_H_ - typedef u8 NDIS_802_11_PMKID_VALUE[16]; u8 rtw_set_802_11_authentication_mode(struct adapter *pdapter, enum ndis_802_11_authentication_mode authmode); diff --git a/drivers/staging/rtl8723bs/include/rtw_wifi_regd.h b/drivers/staging/rtl8723bs/include/rtw_wifi_regd.h index e611651cb40b..e4d8fe9bf68d 100644 --- a/drivers/staging/rtl8723bs/include/rtw_wifi_regd.h +++ b/drivers/staging/rtl8723bs/include/rtw_wifi_regd.h @@ -13,5 +13,4 @@ void rtw_regd_init(struct wiphy *wiphy, struct regulatory_request *request)); void rtw_reg_notifier(struct wiphy *wiphy, struct regulatory_request *request); - #endif diff --git a/drivers/staging/rtl8723bs/include/sdio_ops_linux.h b/drivers/staging/rtl8723bs/include/sdio_ops_linux.h index 18830dd18372..cd67a7201065 100644 --- a/drivers/staging/rtl8723bs/include/sdio_ops_linux.h +++ b/drivers/staging/rtl8723bs/include/sdio_ops_linux.h @@ -25,6 +25,5 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, u32 v, s32 *err); s32 _sd_write(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, void *pdata); s32 sd_write(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, void *pdata); - void rtw_sdio_set_irq_thd(struct dvobj_priv *dvobj, void *thd_hdl); #endif -- 2.52.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] staging: rtl8723bs: Remove extern from function prototypes in cmd_osdep.h 2026-05-10 17:51 [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Pramod Maurya 2026-05-10 17:51 ` [PATCH v2 1/2] staging: rtl8723bs: Remove multiple blank lines " Pramod Maurya @ 2026-05-10 17:51 ` Pramod Maurya 2026-05-11 8:09 ` Greg KH 2026-05-10 20:08 ` [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Nikolay Kulikov 2 siblings, 1 reply; 5+ messages in thread From: Pramod Maurya @ 2026-05-10 17:51 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, nikolayof23, Pramod Maurya The extern keyword is redundant on function declarations in header files. Remove it from all prototypes in cmd_osdep.h and fix extra whitespace in the struct parameter types while at it. Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com> --- drivers/staging/rtl8723bs/include/cmd_osdep.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/cmd_osdep.h b/drivers/staging/rtl8723bs/include/cmd_osdep.h index 41daa3c339a8..4e52e7240058 100644 --- a/drivers/staging/rtl8723bs/include/cmd_osdep.h +++ b/drivers/staging/rtl8723bs/include/cmd_osdep.h @@ -7,11 +7,11 @@ #ifndef __CMD_OSDEP_H_ #define __CMD_OSDEP_H_ -int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv); +int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv); int rtw_init_evt_priv(struct evt_priv *pevtpriv); -extern void _rtw_free_evt_priv(struct evt_priv *pevtpriv); -extern void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv); +void _rtw_free_evt_priv(struct evt_priv *pevtpriv); +void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv); int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj); -extern struct cmd_obj *_rtw_dequeue_cmd(struct __queue *queue); +struct cmd_obj *_rtw_dequeue_cmd(struct __queue *queue); #endif -- 2.52.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] staging: rtl8723bs: Remove extern from function prototypes in cmd_osdep.h 2026-05-10 17:51 ` [PATCH v2 2/2] staging: rtl8723bs: Remove extern from function prototypes in cmd_osdep.h Pramod Maurya @ 2026-05-11 8:09 ` Greg KH 0 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2026-05-11 8:09 UTC (permalink / raw) To: Pramod Maurya; +Cc: linux-staging, linux-kernel, nikolayof23 On Sun, May 10, 2026 at 01:51:03PM -0400, Pramod Maurya wrote: > The extern keyword is redundant on function declarations in header files. > Remove it from all prototypes in cmd_osdep.h and fix extra whitespace > in the struct parameter types while at it. > > Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com> > --- > drivers/staging/rtl8723bs/include/cmd_osdep.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/cmd_osdep.h b/drivers/staging/rtl8723bs/include/cmd_osdep.h > index 41daa3c339a8..4e52e7240058 100644 > --- a/drivers/staging/rtl8723bs/include/cmd_osdep.h > +++ b/drivers/staging/rtl8723bs/include/cmd_osdep.h > @@ -7,11 +7,11 @@ > #ifndef __CMD_OSDEP_H_ > #define __CMD_OSDEP_H_ > > -int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv); > +int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv); This is not an extern change :( ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers 2026-05-10 17:51 [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Pramod Maurya 2026-05-10 17:51 ` [PATCH v2 1/2] staging: rtl8723bs: Remove multiple blank lines " Pramod Maurya 2026-05-10 17:51 ` [PATCH v2 2/2] staging: rtl8723bs: Remove extern from function prototypes in cmd_osdep.h Pramod Maurya @ 2026-05-10 20:08 ` Nikolay Kulikov 2 siblings, 0 replies; 5+ messages in thread From: Nikolay Kulikov @ 2026-05-10 20:08 UTC (permalink / raw) To: Pramod Maurya; +Cc: gregkh, linux-staging, linux-kernel On Sun, May 10, 2026 at 01:51:01PM -0400, Pramod Maurya wrote: > This series fixes two separate checkpatch.pl warnings in the rtl8723bs > include headers, split into one patch per logical change: > > 1. Remove superfluous consecutive blank lines from six header files. > 2. Remove the redundant extern keyword from function prototype > declarations in cmd_osdep.h and fix extra whitespace in struct > parameter types. > > v2: Split into one patch per logical change as requested by Nikolay > Kulikov. Added cover letter. Previous combined patch was sent as > "[PATCH 2/2] staging: rtl8723bs: Fix coding style in include headers". > > Pramod Maurya (2): > staging: rtl8723bs: Remove multiple blank lines in include headers > staging: rtl8723bs: Remove extern from function prototypes in > cmd_osdep.h > > drivers/staging/rtl8723bs/include/cmd_osdep.h | 9 ++++----- > drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 1 - > drivers/staging/rtl8723bs/include/rtl8723b_dm.h | 1 - > drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 1 - > drivers/staging/rtl8723bs/include/rtw_wifi_regd.h | 1 - > drivers/staging/rtl8723bs/include/sdio_ops_linux.h | 1 - > 6 files changed, 4 insertions(+), 10 deletions(-) > > -- > 2.52.0 > Looks good to me. Reviewed-by: Nikolay Kulikov <nikolayof23@gmail.com> Thanks, Nikolay ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-05-11 8:09 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-05-10 17:51 [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Pramod Maurya 2026-05-10 17:51 ` [PATCH v2 1/2] staging: rtl8723bs: Remove multiple blank lines " Pramod Maurya 2026-05-10 17:51 ` [PATCH v2 2/2] staging: rtl8723bs: Remove extern from function prototypes in cmd_osdep.h Pramod Maurya 2026-05-11 8:09 ` Greg KH 2026-05-10 20:08 ` [PATCH v2 0/2] staging: rtl8723bs: Clean up coding style in include headers Nikolay Kulikov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.