All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Andrei Khomenkov <khomenkov@mailbox.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH 9/9] staging: rtl8723bs: simplify if-else blocks in rtw_mlme_ext.c
Date: Mon, 11 May 2026 07:13:42 +0300	[thread overview]
Message-ID: <agFXdkdfheNSrhCb@archlinux> (raw)
In-Reply-To: <20260510134315.64295-10-khomenkov@mailbox.org>

On Sun, May 10, 2026 at 04:43:15PM +0300, Andrei Khomenkov wrote:
> Fix indentation, remove unnecessary braces, and wrap long lines
> in if-else blocks inside the site_survey function.
			       ^^^^^^^^^^^
Again, better with brackets: site_survey().


Thanks,
Nikolay
> 
> Signed-off-by: Andrei Khomenkov <khomenkov@mailbox.org>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 7ac23ccb39f7..2667adc30b00 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -3741,11 +3741,11 @@ void site_survey(struct adapter *padapter)
>  	}
>  
>  	if (survey_channel != 0) {
> -		if (pmlmeext->sitesurvey_res.channel_idx == 0) {
> -				set_channel_bwmode(padapter, survey_channel, HAL_PRIME_CHNL_OFFSET_DONT_CARE, CHANNEL_WIDTH_20);
> -		} else {
> -				r8723bs_select_channel(padapter, survey_channel);
> -		}
> +		if (pmlmeext->sitesurvey_res.channel_idx == 0)
> +			set_channel_bwmode(padapter, survey_channel,
> +					   HAL_PRIME_CHNL_OFFSET_DONT_CARE, CHANNEL_WIDTH_20);
> +		else
> +			r8723bs_select_channel(padapter, survey_channel);
>  
>  		if (ScanType == SCAN_ACTIVE) { /* obey the channel plan setting... */
>  			{
> -- 
> 2.47.3
> 

      reply	other threads:[~2026-05-11  4:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 13:43 [PATCH 0/9] remove unused code and simplify if-else blocks Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 1/9] staging: rtl8723bs: remove unused DBG_FIXED_CHAN code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 2/9] staging: rtl8723bs: remove unused DBG_RX_DUMP_EAP code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 3/9] staging: rtl8723bs: remove unused CONSISTENT_PN_ORDER code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 4/9] staging: rtl8723bs: remove unused DBG_CH_SWITCH code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 5/9] staging: rtl8723bs: remove unused REMOVE_PACK code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 6/9] staging: rtl8723bs: remove unused RTW_DVOBJ_CHIP_HW_TYPE code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 7/9] staging: rtl8723bs: remove unused RTW_MLME_EXT_C_ code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 8/9] staging: rtl8723bs: remove commented out code in rtw_mlme_ext.c Andrei Khomenkov
2026-05-11  4:07   ` Nikolay Kulikov
2026-05-11  9:03     ` Dan Carpenter
2026-05-11 12:59       ` Nikolay Kulikov
2026-05-10 13:43 ` [PATCH 9/9] staging: rtl8723bs: simplify if-else blocks " Andrei Khomenkov
2026-05-11  4:13   ` Nikolay Kulikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agFXdkdfheNSrhCb@archlinux \
    --to=nikolayof23@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=khomenkov@mailbox.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.