From: Dan Carpenter <error27@gmail.com>
To: Nikolay Kulikov <nikolayof23@gmail.com>
Cc: Andrei Khomenkov <khomenkov@mailbox.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 8/9] staging: rtl8723bs: remove commented out code in rtw_mlme_ext.c
Date: Mon, 11 May 2026 12:03:53 +0300 [thread overview]
Message-ID: <agGbearJiYajq7rv@stanley.mountain> (raw)
In-Reply-To: <agFV6Bpe_HyxC4qG@archlinux>
On Mon, May 11, 2026 at 07:07:04AM +0300, Nikolay Kulikov wrote:
> On Sun, May 10, 2026 at 04:43:14PM +0300, Andrei Khomenkov wrote:
> > Remove commented out code in the site_survey function as it is not used.
> ^^^^^^^^^^^
> It is better to indicate function names with brackets: site_survey().
>
I feel like we can go mad with these sorts of review comments. I spent
five minute reviewing all these patches and now I have to review them
all again because of this really minor thing?
My trick for minor review comments, is that I try to find a real bug
and I tie the minor thing to a major comment. "Sorry, you forgot to
add clean up on error and also you forgot a comma in your commit
message".
There a lot of minor stuff that I end up ignoring...
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-11 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 13:43 [PATCH 0/9] remove unused code and simplify if-else blocks Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 1/9] staging: rtl8723bs: remove unused DBG_FIXED_CHAN code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 2/9] staging: rtl8723bs: remove unused DBG_RX_DUMP_EAP code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 3/9] staging: rtl8723bs: remove unused CONSISTENT_PN_ORDER code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 4/9] staging: rtl8723bs: remove unused DBG_CH_SWITCH code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 5/9] staging: rtl8723bs: remove unused REMOVE_PACK code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 6/9] staging: rtl8723bs: remove unused RTW_DVOBJ_CHIP_HW_TYPE code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 7/9] staging: rtl8723bs: remove unused RTW_MLME_EXT_C_ code Andrei Khomenkov
2026-05-10 13:43 ` [PATCH 8/9] staging: rtl8723bs: remove commented out code in rtw_mlme_ext.c Andrei Khomenkov
2026-05-11 4:07 ` Nikolay Kulikov
2026-05-11 9:03 ` Dan Carpenter [this message]
2026-05-11 12:59 ` Nikolay Kulikov
2026-05-10 13:43 ` [PATCH 9/9] staging: rtl8723bs: simplify if-else blocks " Andrei Khomenkov
2026-05-11 4:13 ` Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agGbearJiYajq7rv@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khomenkov@mailbox.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.