Re: [PATCH RFC 0/5] hw/riscv: Add support for Milk-V Duo board

[Kuan-Wei Chiu <visitorckw@gmail.com>]

Hi Alistair,

On Wed, May 13, 2026 at 12:27:37PM +1000, Alistair Francis wrote:
> On Tue, May 12, 2026 at 7:47 PM Kuan-Wei Chiu <visitorckw@gmail.com> wrote:
> >
> > Add initial support for the Milk-V Duo board.
> >
> > This is something I've been playing around with in my local branch, and
> > I've reached a point where the implementation is enough to boot OpenSBI
> > and reach a Linux shell using an SD card image.
> 
> Great job!
> 
> >
> > I am sending this as an RFC to get early feedback to understand the gap
> > between this minimal implementation and what is required for a upstream
> > merge. I plan to continue implementing missing blocks (like gpio and
> > clk/rst) in future.
> 
> Overall this looks good and is going in the right direction. Being
> able to boot Linux is a great start and a good achievement.
> 
> This could be submitted now, there is no requirement to add extra
> functionality to upstream it. It would be great if you could add some
> unit tests as well, so then we can test this as part of the QEMU CI.
> 
Thanks for the prompt response and the review!
I'll try to add some tests and send out as v2.

Regards,
Kuan-Wei