Perf review prompts

Perf review prompts

[Ian Rogers]

Hi,

I think we can improve the review prompts for Sashiko and others, so I
sent out this PR:
https://github.com/masoncl/review-prompts/pull/62
I wanted to advertise this and suggest that others contribute similarly.

Thanks,
Ian

Re: Perf review prompts

[Arnaldo Carvalho de Melo]

On Fri, May 15, 2026 at 04:52:43PM -0700, Ian Rogers wrote:
> I think we can improve the review prompts for Sashiko and others, so I
> sent out this PR:
> https://github.com/masoncl/review-prompts/pull/62
> I wanted to advertise this and suggest that others contribute similarly.

Thanks for working on this, from a quick look it seems sane, some
comments:

-----
The "File Descriptor and Directory Stream Management" is describing
the dir equivalent of open and close and saying they need to be
paired. Assume this is base knowledge for an AI code review tool.
-----

That is completely reasonable expectation, I would be surprised if it
wouldn't catch this, but have you tested it?

For the validation of perf.data headers I plan to contribute what I
learned while working on:

  [PATCH 00/28] perf: Harden perf.data parsing against crafted/corrupted files
  https://lore.kernel.org/all/20260510033424.255812-1-acme@kernel.org>

That I hope soon to satisfy the last review comments from sashiko
addressed.

Anyway, I think this can be added FWIW:

Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>

- Arnaldo