From: dmukhin@ford.com
To: Jiaqing Zhao <Zhao.Jiaqing@amd.com>
Cc: xen-devel@lists.xenproject.org,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Jan Beulich" <jbeulich@suse.com>,
"Julien Grall" <julien@xen.org>,
"Michal Orzel" <michal.orzel@amd.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>
Subject: Re: [PATCH v5 1/3] ns16550: properly initialize booleans in uart_param[]
Date: Tue, 2 Jun 2026 10:11:13 -0700 [thread overview]
Message-ID: <ah8OsWLjojlMiNSA@kraken> (raw)
In-Reply-To: <20260602161322.1039349-2-Zhao.Jiaqing@amd.com>
On Wed, Jun 03, 2026 at 12:13:20AM +0800, Jiaqing Zhao wrote:
> .bar0 and .mmio in struct ns16550_config_param are booleans, hence they
> should be initialized with "true", not "1". No functional change.
>
> Signed-off-by: Jiaqing Zhao <Zhao.Jiaqing@amd.com>
Reviewed-by: Denis Mukhin <dmukhin@ford.com>
> ---
> xen/drivers/char/ns16550.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
> index 878da27f2e..ed4e29ec25 100644
> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -758,7 +758,7 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 16,
> .lsr_mask = (UART_LSR_THRE | UART_LSR_TEMT),
> - .mmio = 1,
> + .mmio = true,
> .max_ports = 1,
> },
> [param_oxford] = {
> @@ -768,7 +768,7 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 16,
> .lsr_mask = UART_LSR_THRE,
> - .mmio = 1,
> + .mmio = true,
> .max_ports = 1, /* It can do more, but we would need more custom code.*/
> },
> [param_oxford_2port] = {
> @@ -778,7 +778,7 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 16,
> .lsr_mask = UART_LSR_THRE,
> - .mmio = 1,
> + .mmio = true,
> .max_ports = 2,
> },
> [param_pericom_1port] = {
> @@ -787,7 +787,7 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 16,
> .lsr_mask = UART_LSR_THRE,
> - .bar0 = 1,
> + .bar0 = true,
> .max_ports = 1,
> },
> [param_pericom_2port] = {
> @@ -796,7 +796,7 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 16,
> .lsr_mask = UART_LSR_THRE,
> - .bar0 = 1,
> + .bar0 = true,
> .max_ports = 2,
> },
> /*
> @@ -809,7 +809,7 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 16,
> .lsr_mask = UART_LSR_THRE,
> - .bar0 = 1,
> + .bar0 = true,
> .max_ports = 4,
> },
> [param_pericom_8port] = {
> @@ -818,7 +818,7 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 16,
> .lsr_mask = UART_LSR_THRE,
> - .bar0 = 1,
> + .bar0 = true,
> .max_ports = 8,
> },
> [param_exar_xr17v352] = {
> @@ -827,8 +827,8 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 256,
> .lsr_mask = UART_LSR_THRE,
> - .bar0 = 1,
> - .mmio = 1,
> + .bar0 = true,
> + .mmio = true,
> .max_ports = 2,
> },
> [param_exar_xr17v354] = {
> @@ -837,8 +837,8 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 256,
> .lsr_mask = UART_LSR_THRE,
> - .bar0 = 1,
> - .mmio = 1,
> + .bar0 = true,
> + .mmio = true,
> .max_ports = 4,
> },
> [param_exar_xr17v358] = {
> @@ -847,8 +847,8 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 256,
> .lsr_mask = UART_LSR_THRE,
> - .bar0 = 1,
> - .mmio = 1,
> + .bar0 = true,
> + .mmio = true,
> .max_ports = 8,
> },
> [param_intel_lpss] = {
> @@ -857,8 +857,8 @@ static const struct ns16550_config_param __initconst uart_param[] = {
> .reg_width = 1,
> .fifo_size = 64,
> .lsr_mask = UART_LSR_THRE,
> - .bar0 = 1,
> - .mmio = 1,
> + .bar0 = true,
> + .mmio = true,
> .max_ports = 1,
> },
> };
> --
> 2.53.0
>
>
next prev parent reply other threads:[~2026-06-02 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 16:13 [PATCH v5 0/3] ns16550: add support for WCH CH382 and ASIX AX99100 Jiaqing Zhao
2026-06-02 16:13 ` [PATCH v5 1/3] ns16550: properly initialize booleans in uart_param[] Jiaqing Zhao
2026-06-02 17:11 ` dmukhin [this message]
2026-06-03 5:45 ` Jan Beulich
2026-06-02 16:13 ` [PATCH v5 2/3] ns16550: add support for WCH CH382 serial adapters Jiaqing Zhao
2026-06-02 16:13 ` [PATCH v5 3/3] ns16550: add support for ASIX AX99100 PCIe Multi-I/O controller Jiaqing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah8OsWLjojlMiNSA@kraken \
--to=dmukhin@ford.com \
--cc=Zhao.Jiaqing@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.