All of lore.kernel.org
 help / color / mirror / Atom feed
* [nft PATCH] tests: shell: packetpath/ct_count: Add missing socat feature test
@ 2026-06-02 13:07 Phil Sutter
  2026-06-02 13:46 ` Florian Westphal
  0 siblings, 1 reply; 3+ messages in thread
From: Phil Sutter @ 2026-06-02 13:07 UTC (permalink / raw)
  To: netfilter-devel

Skip the test on systems which don't have socat installed.

Fixes: 95e4cbf6b63c2 ("tests: shell: add simple 'ct count' test case")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 tests/shell/testcases/packetpath/ct_count | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/shell/testcases/packetpath/ct_count b/tests/shell/testcases/packetpath/ct_count
index 06f586ed7cce5..77efc715be3be 100755
--- a/tests/shell/testcases/packetpath/ct_count
+++ b/tests/shell/testcases/packetpath/ct_count
@@ -1,6 +1,8 @@
 #!/bin/bash
 # Test nftables connlimit functionality using network namespaces and socat
 
+# NFT_TEST_REQUIRES(NFT_TEST_HAVE_socat)
+
 . $NFT_TEST_LIBRARY_FILE
 
 set -e
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [nft PATCH] tests: shell: packetpath/ct_count: Add missing socat feature test
  2026-06-02 13:07 [nft PATCH] tests: shell: packetpath/ct_count: Add missing socat feature test Phil Sutter
@ 2026-06-02 13:46 ` Florian Westphal
  2026-06-02 19:02   ` Phil Sutter
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Westphal @ 2026-06-02 13:46 UTC (permalink / raw)
  To: Phil Sutter; +Cc: netfilter-devel

Phil Sutter <phil@nwl.cc> wrote:
> Skip the test on systems which don't have socat installed.

Ah, thanks. Please apply.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [nft PATCH] tests: shell: packetpath/ct_count: Add missing socat feature test
  2026-06-02 13:46 ` Florian Westphal
@ 2026-06-02 19:02   ` Phil Sutter
  0 siblings, 0 replies; 3+ messages in thread
From: Phil Sutter @ 2026-06-02 19:02 UTC (permalink / raw)
  To: Florian Westphal; +Cc: netfilter-devel

On Tue, Jun 02, 2026 at 03:46:28PM +0200, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > Skip the test on systems which don't have socat installed.
> 
> Ah, thanks. Please apply.

Done already, sorry for not sending an "applied" message.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-02 19:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-02 13:07 [nft PATCH] tests: shell: packetpath/ct_count: Add missing socat feature test Phil Sutter
2026-06-02 13:46 ` Florian Westphal
2026-06-02 19:02   ` Phil Sutter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.