From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Teddy Astie <teddy.astie@vates.tech>
Subject: Re: [PATCH 5/5] x86/shadow: rename a parameter of shadow_l<N>_index()
Date: Fri, 22 May 2026 12:30:25 +0200 [thread overview]
Message-ID: <ahAwQQiWxLnWtmP7@macbook.local> (raw)
In-Reply-To: <8aca671a-eb6f-475d-87cb-7a738ecd0793@suse.com>
On Wed, May 13, 2026 at 01:46:59PM +0200, Jan Beulich wrote:
> ... shadowing a file scope one, thus violating Misra C:2012 rule 5.3
> ("An identifier declared in an inner scope shall not hide an identifier
> declared in an outer scope").
>
> While there,
> - replace u32 by uint32_t,
> - reduce the number of cf_check by aliasing shadow_l<N>_index() to
> shadow_l1_index() for N > 1 and GUEST_PAGING_LEVELS > 2.
>
> No difference in generated code, except of course the removal of the
> duplicate function instances.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
prev parent reply other threads:[~2026-05-22 10:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 11:43 [PATCH 0/5] x86: Misra rule 5.3 Jan Beulich
2026-05-13 11:44 ` [PATCH 1/5] x86/guest: rename a local variable Jan Beulich
2026-05-13 21:17 ` Nicola Vetrini
2026-05-15 11:00 ` Andrew Cooper
2026-05-13 11:44 ` [PATCH 2/5] x86/PV: rename a local variable in pv_emulate_gate_op() Jan Beulich
2026-05-22 10:24 ` Roger Pau Monné
2026-05-22 10:25 ` Andrew Cooper
2026-05-13 11:45 ` [PATCH 3/5] x86/shadow: conditionalize / rename local variables Jan Beulich
2026-05-22 10:28 ` Roger Pau Monné
2026-05-13 11:46 ` [PATCH 4/5] x86/shadow: split a nested max() invocation Jan Beulich
2026-05-14 5:08 ` Nicola Vetrini
2026-05-15 6:15 ` Jan Beulich
2026-05-13 11:46 ` [PATCH 5/5] x86/shadow: rename a parameter of shadow_l<N>_index() Jan Beulich
2026-05-22 10:30 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahAwQQiWxLnWtmP7@macbook.local \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.