From: Dan Carpenter <error27@gmail.com>
To: Ahmet Sezgin Duran <ahmet@sezginduran.net>
Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] staging: sm750fb: deduplicate fbinfo loop in suspend/resume
Date: Mon, 25 May 2026 19:13:47 +0300 [thread overview]
Message-ID: <ahR1O_dF9XyVEmPo@stanley.mountain> (raw)
In-Reply-To: <86216e7d-7867-4041-892b-aafeb39781b8@sezginduran.net>
On Mon, May 25, 2026 at 11:23:43AM +0300, Ahmet Sezgin Duran wrote:
> On 5/25/26 11:01 AM, Dan Carpenter wrote:
> > I was waiting to see if anyone had other comments bout this patchset
> > to decide if I should mention these minor nits. But then I was
> > confused about v2 so I think there might end up being comments... :P
>
> v2 was only about dropping another patch from series, no change for this
> patch. (would be better to talk this in v2 mails, but I guess it's no big
> deal.)
I thought you were going to to abandon the ARRAY_SIZE(cdb) in v2.
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-25 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 5:15 [PATCH 0/5] staging: sm750fb: various code cleanups Ahmet Sezgin Duran
2026-05-23 5:15 ` [PATCH 1/5] staging: sm750fb: remove commented-out forward declarations Ahmet Sezgin Duran
2026-05-23 5:15 ` [PATCH 2/5] staging: sm750fb: remove unnecessary initializations Ahmet Sezgin Duran
2026-05-23 5:15 ` [PATCH 3/5] staging: sm750fb: remove unused struct fields Ahmet Sezgin Duran
2026-05-23 5:15 ` [PATCH 4/5] staging: sm750fb: use ARRAY_SIZE macro in fb_find_mode loop Ahmet Sezgin Duran
2026-05-23 10:07 ` Dan Carpenter
2026-05-23 15:06 ` Ahmet Sezgin Duran
2026-05-23 16:26 ` David Laight
2026-05-23 5:15 ` [PATCH 5/5] staging: sm750fb: deduplicate fbinfo loop in suspend/resume Ahmet Sezgin Duran
2026-05-25 8:01 ` Dan Carpenter
2026-05-25 8:23 ` Ahmet Sezgin Duran
2026-05-25 16:13 ` Dan Carpenter [this message]
2026-05-25 16:31 ` Ahmet Sezgin Duran
2026-05-25 17:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahR1O_dF9XyVEmPo@stanley.mountain \
--to=error27@gmail.com \
--cc=ahmet@sezginduran.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.