All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Zeng Heng <zengheng@huaweicloud.com>
Cc: will@kernel.org, akpm@linux-foundation.org, npiggin@gmail.com,
	aneesh.kumar@kernel.org, peterz@infradead.org,
	linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com,
	linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
	linux-arch@vger.kernel.org, zengheng4@huawei.com,
	sunnanyong@huawei.com, blingxue@tencent.com
Subject: Re: [PATCH] arm64: tlb: Flush walk cache when unsharing PMD tables
Date: Tue, 26 May 2026 14:01:20 +0100	[thread overview]
Message-ID: <ahWZoD9Ubaxx-GdK@arm.com> (raw)
In-Reply-To: <f5b7460a-5719-bdb2-c53b-413468857f57@huaweicloud.com>

On Mon, May 25, 2026 at 05:20:14PM +0800, Zeng Heng wrote:
> On 2026/5/22 18:42, Catalin Marinas wrote:
> > On Thu, 21 May 2026 15:30:11 +0800, Zeng Heng wrote:
> > > When huge_pmd_unshare() is called to unshare a PMD table, the
> > > tlb_unshare_pmd_ptdesc() function sets tlb->unshared_tables=true
> > > but the aarch64 tlb_flush() only checked tlb->freed_tables to
> > > determine whether to use TLBF_NONE (vae1is, invalidates walk
> > > cache) or TLBF_NOWALKCACHE (vale1is, leaf-only).
> > > 
> > > This caused the stale PMD page table entry to remain in the walk cache
> > > after unshare, potentially leading to incorrect page table walks.
> > > 
> > > [...]
> > Applied to arm64 (for-next/fixes), thanks!
> > 
> > [1/1] arm64: tlb: Flush walk cache when unsharing PMD tables
> >        https://git.kernel.org/arm64/c/c2ff4764e03e
> 
> This original issue was reported by our customer, who also participated
> in the root cause analysis and resolution.
> 
> Could you please help add the below tags:
> 
> Co-developed-by: Xue Xiaowei <blingxue@tencent.com>
> Signed-off-by: Xue Xiaowei <blingxue@tencent.com>
> 
> Thank you in advance.

Too late unfortunately, the pull request went in on Friday. It will be
in the list archives though.

-- 
Catalin


      reply	other threads:[~2026-05-26 13:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  7:30 [PATCH] arm64: tlb: Flush walk cache when unsharing PMD tables Zeng Heng
2026-05-21 15:05 ` Catalin Marinas
2026-05-21 15:15   ` Catalin Marinas
2026-05-22  5:32     ` Zeng Heng
2026-05-22 10:13       ` Catalin Marinas
2026-05-22 10:38         ` Catalin Marinas
2026-05-25  1:25           ` Zeng Heng
2026-05-22  4:43   ` Zeng Heng
2026-05-22 10:42 ` Catalin Marinas
2026-05-25  9:20   ` Zeng Heng
2026-05-26 13:01     ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahWZoD9Ubaxx-GdK@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@kernel.org \
    --cc=blingxue@tencent.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@gmail.com \
    --cc=peterz@infradead.org \
    --cc=sunnanyong@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=zengheng4@huawei.com \
    --cc=zengheng@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.