From: Jiri Olsa <olsajiri@gmail.com>
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
bpf@vger.kernel.org
Subject: Re: [PATCHv3 07/12] selftests/bpf: Emit nop,nop10 instructions combo for x86_64 arch
Date: Tue, 26 May 2026 16:30:14 +0200 [thread overview]
Message-ID: <ahWudlB0zTRvfBE6@krava> (raw)
In-Reply-To: <87bje277zf.fsf@cloudflare.com>
On Tue, May 26, 2026 at 12:58:28PM +0200, Jakub Sitnicki wrote:
> On Thu, May 21, 2026 at 01:21 PM GMT, sashiko-bot@kernel.org wrote:
>
> [...]
>
> > Would using two consecutive 5-byte nops instead of a single 10-byte
> > nop safely provide the padding needed for a 5-byte patch?
>
> Perhaps worth clarifying that nop5,nop5 wouldn't allow us to leave the
> CALL in nop10 tail after the optimize/unoptimize cycle.
right, also we need to have single instruction for that
to have some assurance the app won't jump in the middle
jirka
next prev parent reply other threads:[~2026-05-26 14:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 12:43 [PATCHv3 00/12] uprobes/x86: Fix red zone issue for optimized uprobes Jiri Olsa
2026-05-21 12:44 ` [PATCHv3 01/12] uprobes/x86: Use proper mm_struct in __in_uprobe_trampoline Jiri Olsa
2026-05-22 18:50 ` Andrii Nakryiko
2026-05-21 12:44 ` [PATCHv3 02/12] uprobes/x86: Remove struct uprobe_trampoline object Jiri Olsa
2026-05-21 13:26 ` bot+bpf-ci
2026-05-24 22:13 ` Jiri Olsa
2026-05-22 18:50 ` Andrii Nakryiko
2026-05-21 12:44 ` [PATCHv3 03/12] uprobes/x86: Allow to copy uprobe trampolines on fork Jiri Olsa
2026-05-22 18:50 ` Andrii Nakryiko
2026-05-24 21:54 ` Jiri Olsa
2026-05-21 12:44 ` [PATCHv3 04/12] uprobes/x86: Move optimized uprobe from nop5 to nop10 Jiri Olsa
2026-05-21 13:35 ` Peter Zijlstra
2026-05-22 21:19 ` Jiri Olsa
2026-05-22 18:50 ` Andrii Nakryiko
2026-05-22 21:19 ` Jiri Olsa
2026-05-26 9:19 ` Peter Zijlstra
2026-05-26 10:19 ` Jiri Olsa
2026-05-21 12:44 ` [PATCHv3 05/12] libbpf: Change has_nop_combo to work on top of nop10 Jiri Olsa
2026-05-21 13:01 ` sashiko-bot
2026-05-22 18:52 ` Andrii Nakryiko
2026-05-22 21:28 ` Jiri Olsa
2026-05-26 14:26 ` Jiri Olsa
2026-05-21 12:44 ` [PATCHv3 06/12] libbpf: Detect uprobe syscall with new error Jiri Olsa
2026-05-21 13:26 ` bot+bpf-ci
2026-05-21 13:29 ` sashiko-bot
2026-05-25 15:44 ` Jiri Olsa
2026-05-21 12:44 ` [PATCHv3 07/12] selftests/bpf: Emit nop,nop10 instructions combo for x86_64 arch Jiri Olsa
2026-05-21 13:21 ` sashiko-bot
2026-05-25 15:43 ` Jiri Olsa
2026-05-26 10:58 ` Jakub Sitnicki
2026-05-26 14:30 ` Jiri Olsa [this message]
2026-05-21 13:26 ` bot+bpf-ci
2026-05-26 10:58 ` Jakub Sitnicki
2026-05-21 12:44 ` [PATCHv3 08/12] selftests/bpf: Change uprobe syscall tests to use nop10 Jiri Olsa
2026-05-21 13:05 ` sashiko-bot
2026-05-21 13:26 ` bot+bpf-ci
2026-05-22 18:57 ` Andrii Nakryiko
2026-05-25 15:44 ` Jiri Olsa
2026-05-21 12:44 ` [PATCHv3 09/12] selftests/bpf: Change uprobe/usdt trigger bench code " Jiri Olsa
2026-05-21 12:44 ` [PATCHv3 10/12] selftests/bpf: Add reattach tests for uprobe syscall Jiri Olsa
2026-05-21 12:44 ` [PATCHv3 11/12] selftests/bpf: Add tests for uprobe nop10 red zone clobbering Jiri Olsa
2026-05-21 13:26 ` bot+bpf-ci
2026-05-25 15:44 ` Jiri Olsa
2026-05-21 12:44 ` [PATCHv3 12/12] selftests/bpf: Add tests for forked/cloned optimized uprobes Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahWudlB0zTRvfBE6@krava \
--to=olsajiri@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=jakub@cloudflare.com \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.