All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/i2c: Report i2c irq handler issue
@ 2026-06-03 20:10 Jonathan Cavitt
  2026-06-03 20:40 ` ✓ CI.KUnit: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Jonathan Cavitt @ 2026-06-03 20:10 UTC (permalink / raw)
  To: intel-xe; +Cc: saurabhg.gupta, alex.zuo, jonathan.cavitt, raag.jadav

xe_i2c_irq_handler calls generic_handle_irq_safe, which can return an
error value.  In all other cases, this is passed to a
.*_err_ratelimited error message helper.  Add the missing error handler.

This issue was caught by static analysis.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>
---
 drivers/gpu/drm/xe/xe_i2c.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
index 706783863d07..acfc171483b2 100644
--- a/drivers/gpu/drm/xe/xe_i2c.c
+++ b/drivers/gpu/drm/xe/xe_i2c.c
@@ -177,12 +177,15 @@ static bool xe_i2c_irq_present(struct xe_device *xe)
 void xe_i2c_irq_handler(struct xe_device *xe, u32 master_ctl)
 {
 	struct xe_mmio *mmio = xe_root_tile_mmio(xe);
+	int ret;
 
 	if (!(master_ctl & I2C_IRQ) || !xe_i2c_irq_present(xe))
 		return;
 
 	/* Forward interrupt to I2C adapter */
-	generic_handle_irq_safe(xe->i2c->adapter_irq);
+	ret = generic_handle_irq_safe(xe->i2c->adapter_irq);
+	if (ret)
+		drm_err_ratelimited(&xe->drm, "error handling i2c irq: %d\n", ret);
 
 	/* Deassert after I2C adapter clears the interrupt */
 	xe_mmio_rmw32(mmio, I2C_CONFIG_CMD, 0, PCI_COMMAND_INTX_DISABLE);
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-06-04 19:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-03 20:10 [PATCH] drm/xe/i2c: Report i2c irq handler issue Jonathan Cavitt
2026-06-03 20:40 ` ✓ CI.KUnit: success for " Patchwork
2026-06-03 21:36 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-06-04 11:30 ` ✓ Xe.CI.FULL: success " Patchwork
2026-06-04 12:38 ` [PATCH] " Raag Jadav
2026-06-04 14:22   ` Cavitt, Jonathan
2026-06-04 19:04     ` Raag Jadav

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.