From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Alistair Francis" <alistair.francis@wdc.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Fabiano Rosas" <farosas@suse.de>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Warner Losh" <imp@bsdimp.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <bonzini@gnu.org>
Subject: Re: [PATCH v2] docs/devel: relax policy on AI-generated contributions
Date: Fri, 5 Jun 2026 12:12:20 +0200 [thread overview]
Message-ID: <aiKhBDfATZ1SkmYm@redhat.com> (raw)
In-Reply-To: <CABgObfZNX2rLnB=FosVopFmLB_S_5V48UPLjNTTtn543d9RfHg@mail.gmail.com>
Am 03.06.2026 um 17:35 hat Paolo Bonzini geschrieben:
> > > +**Small bug fixes**
> > > + These should be limited to 20 lines of code or less, not including
> > > + tests. You are still expected to :ref:`understand and explain your changes
> > > + <write_a_meaningful_commit_message>` and the rationale behind them.
> >
> > I think the "20 lines or less" is not going a good job at expressing
> > the intent behind this point. I'd like us to emphasize between the
> > "why" of this point, as that helps contributors & reviewers make a
> > decision of whether a change is "within the spirit" or the rule of
> > not.
>
> True but we also need a rule. The spirit is better explained elsewhere
> (and also, building consensus on spirit vs. a rule are two different
> things).
But "20 lines or less" is still not a good rule because it measures
something that isn't really what we're after. The rule is "trivial
code", and yes, there is no good way to measure that. But that's not a
good reason to replace it with a metric as good as defining productivity
of an engineer by lines of code added.
Can we turn this just into an example, and also be a bit more specific?
Like "20 lines of low complexity code"? (Or is it more like "moderate
complexity" that you have in mind?) But it's definitely possible to
write 20 lines that aren't trivial at all, so the rule shouldn't allow
that.
> > Docs is an area I'm more wary of from the social expectation side rather
> > than the technical or legal side. I don't feeel like "pay attention to
> > the organization and flow" really mitigates to the tendancy to production
> > of vast reams of convincing sounding slop.
>
> Reviewers have no obligation to review. The good thing about slop is
> that saying no takes about the same effort as the author put into the
> creation of the change.
Just saying "no, because I don't feel like reviewing this" is actually a
new thing for most of us, and doesn't feel very comfortable. We may need
to get used to it, but I don't think it's easy.
> > > +There is no requirement to include your prompts or summarize the
> > > +conversation in the commit message or cover letter, but you may do so
> > > +if you think it helps a reviewer judge the result. For example:
> >
> > IMHO we should actively discourage the inclusion of prompts
> > entirely as it is the wrong information to provide.
>
> Why? I think it helps especially in the case where we're asking for
> maintainers to apply their discretion, and for reproducibility. It may
> not be always applicable, but it can also help.
Not sure how much reproducibility there can possibly be with LLMs. :-)
Kevin
next prev parent reply other threads:[~2026-06-05 10:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 9:46 [PATCH v2] docs/devel: relax policy on AI-generated contributions Paolo Bonzini
2026-05-29 11:52 ` Alex Bennée
2026-05-29 13:06 ` Paolo Bonzini
2026-05-29 13:10 ` Michael S. Tsirkin
2026-05-29 11:59 ` BALATON Zoltan
2026-05-29 15:34 ` Peter Maydell
2026-05-29 15:46 ` Michael S. Tsirkin
2026-05-29 15:55 ` Peter Maydell
2026-05-29 16:17 ` Paolo Bonzini
2026-05-29 17:47 ` Michael S. Tsirkin
2026-06-02 7:38 ` Michael S. Tsirkin
2026-06-02 8:09 ` Paolo Bonzini
2026-06-02 15:53 ` Stefan Hajnoczi
2026-06-03 11:35 ` Paolo Bonzini
2026-06-03 14:55 ` Stefan Hajnoczi
2026-06-03 14:59 ` Daniel P. Berrangé
2026-06-03 15:06 ` Michael S. Tsirkin
2026-06-03 15:35 ` Paolo Bonzini
2026-06-03 17:54 ` Daniel P. Berrangé
2026-06-04 10:37 ` Paolo Bonzini
2026-06-05 9:17 ` Daniel P. Berrangé
2026-06-05 9:25 ` Michael S. Tsirkin
2026-06-05 9:39 ` Daniel P. Berrangé
2026-06-05 9:48 ` Michael S. Tsirkin
2026-06-05 10:23 ` Daniel P. Berrangé
2026-06-05 10:28 ` Michael S. Tsirkin
2026-06-05 10:34 ` Daniel P. Berrangé
2026-06-05 11:26 ` Paolo Bonzini
2026-06-05 12:39 ` BALATON Zoltan
2026-06-05 13:00 ` Daniel P. Berrangé
2026-06-03 18:14 ` Alex Bennée
2026-06-03 18:20 ` Daniel P. Berrangé
2026-06-04 10:04 ` Alex Bennée
2026-06-04 6:08 ` Michael S. Tsirkin
2026-06-05 10:12 ` Kevin Wolf [this message]
2026-06-05 10:23 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiKhBDfATZ1SkmYm@redhat.com \
--to=kwolf@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=balaton@eik.bme.hu \
--cc=berrange@redhat.com \
--cc=bonzini@gnu.org \
--cc=farosas@suse.de \
--cc=imp@bsdimp.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.