All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Patel <ripatel@wii.dev>
To: Paul Walmsley <pjw@kernel.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Deepak Gupta <debug@rivosinc.com>, Zong Li <zong.li@sifive.com>,
	Charlie Jenkins <charlie@rivosinc.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: cfi: reject unknown flags in PR_SET_CFI
Date: Fri, 5 Jun 2026 15:10:31 +0000	[thread overview]
Message-ID: <aiLm58Sjuj8XAaSF@wii.dev> (raw)
In-Reply-To: <3f2d4628-a95d-89c3-2fd7-3e1a407d698a@kernel.org>

On Thu, Jun 04, 2026 at 04:40:31PM -0600, Paul Walmsley wrote:
> Hi,
> 
> On Mon, 18 May 2026, Richard Patel wrote:
> 
> > prctl(PR_SET_CFI,PR_CFI_BRANCH_LANDING_PADS) silently ignored
> > unknown control values. Only PR_CFI_{ENABLE,DISABLE,LOCK} should
> > be permitted.
> <
> > This is a uABI breaking change (fails previously accepted bits
> > with EINVAL).
> 
> Thanks for the patch.  However, I'm not convinced that this actually 
> breaks anything.  The behavior of the interface changes when unknown flags 
> are specified, but I'm not aware of anything that relies on this specific 
> behavior.
> 
> Does that match your understanding?

I agree, yes, happy to rephrase the commit message.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Richard Patel <ripatel@wii.dev>
To: Paul Walmsley <pjw@kernel.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Deepak Gupta <debug@rivosinc.com>, Zong Li <zong.li@sifive.com>,
	Charlie Jenkins <charlie@rivosinc.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: cfi: reject unknown flags in PR_SET_CFI
Date: Fri, 5 Jun 2026 15:10:31 +0000	[thread overview]
Message-ID: <aiLm58Sjuj8XAaSF@wii.dev> (raw)
In-Reply-To: <3f2d4628-a95d-89c3-2fd7-3e1a407d698a@kernel.org>

On Thu, Jun 04, 2026 at 04:40:31PM -0600, Paul Walmsley wrote:
> Hi,
> 
> On Mon, 18 May 2026, Richard Patel wrote:
> 
> > prctl(PR_SET_CFI,PR_CFI_BRANCH_LANDING_PADS) silently ignored
> > unknown control values. Only PR_CFI_{ENABLE,DISABLE,LOCK} should
> > be permitted.
> <
> > This is a uABI breaking change (fails previously accepted bits
> > with EINVAL).
> 
> Thanks for the patch.  However, I'm not convinced that this actually 
> breaks anything.  The behavior of the interface changes when unknown flags 
> are specified, but I'm not aware of anything that relies on this specific 
> behavior.
> 
> Does that match your understanding?

I agree, yes, happy to rephrase the commit message.

  reply	other threads:[~2026-06-05 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 18:39 [PATCH] riscv: cfi: reject unknown flags in PR_SET_CFI Richard Patel
2026-05-18 18:39 ` Richard Patel
2026-06-04 22:40 ` Paul Walmsley
2026-06-04 22:40   ` Paul Walmsley
2026-06-05 15:10   ` Richard Patel [this message]
2026-06-05 15:10     ` Richard Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiLm58Sjuj8XAaSF@wii.dev \
    --to=ripatel@wii.dev \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=charlie@rivosinc.com \
    --cc=debug@rivosinc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=shuah@kernel.org \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.