All of lore.kernel.org
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Marco Crivellari <marco.crivellari@suse.com>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
	 Joe Perches <joe@perches.com>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	 Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Tejun Heo <tj@kernel.org>,
	 Frederic Weisbecker <frederic@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	 Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v4] checkpatch: Check WQ_PERCPU or WQ_UNBOUND presence in alloc_workqueue() users
Date: Mon, 8 Jun 2026 02:33:17 -0700	[thread overview]
Message-ID: <aiaMLn2oDGkagUzr@gmail.com> (raw)
In-Reply-To: <20260608083711.76885-1-marco.crivellari@suse.com>

On Mon, Jun 08, 2026 at 10:37:11AM +0200, Marco Crivellari wrote:
> The workqueue API introduced a new flag, WQ_PERCPU, that has to be used when
> WQ_UNBOUND is not present. One of these flags must be present, but not
> both of them.
> 
> To limit usage mistakes, emit an ERROR if one of the below condition is met:

The changelog still says "emit an ERROR", but since v3 the code uses
WARN()

> - alloc_workqueue() is called without WQ_PERCPU nor WQ_UNBOUND
> - alloc_workqueue() is called with both WQ_PERCPU and WQ_UNBOUND
> 
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>

Reviewed-by: Breno Leitao <leitao@debian.org>

  reply	other threads:[~2026-06-08  9:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08  8:37 [PATCH v4] checkpatch: Check WQ_PERCPU or WQ_UNBOUND presence in alloc_workqueue() users Marco Crivellari
2026-06-08  9:33 ` Breno Leitao [this message]
2026-06-08 12:31   ` Marco Crivellari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiaMLn2oDGkagUzr@gmail.com \
    --to=leitao@debian.org \
    --cc=apw@canonical.com \
    --cc=bigeasy@linutronix.de \
    --cc=dwaipayanray1@gmail.com \
    --cc=frederic@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=marco.crivellari@suse.com \
    --cc=mhocko@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.