Re: [PATCH] get_maintainer: add recipients to output of script

[Agatha Isabelle Moreira <code@agatha.dev>]

On Mon, Jun 08, 2026 at 06:34:12PM +0200, Manuel Ebner wrote:
> Add all people tagged in all the mentioned commits to the output of this script.
> This is done to give credit to people who inspired the current commit or to get
> feedback from people who know the subject.

Some things to notice:
1) Cc someone in the message is not the way of giving credit, the tags
are already for that.

2) The way get_maintainer.pl works today already copies the relevant
people, you should state why your addition matters to that.

3) You are supposed to send the message again with `[PATCH v2]` in the
subject if you want your message to be tracked as a new version of the
patch. In that case you must include a changelog stating your changes.

See: https://docs.kernel.org/process/submitting-patches.html

4) I'm not sure why people in the mentioned patches should necessarily
be copied in a patch. I mean, if they are active contributors to that
part of the code they are likely already included in the regular
`get_maintainer.pl` output, they will either be listed in the
`MAINTAINERS` file or at least be fetched through git.

Keep in mind that `get_maintainer.pl` is not intended to be used to spam
people, but to get where to send your patches and who to copy. 

> index 16b80a700d4a..8c44b14391f9 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -30,6 +30,7 @@ my $email_usename = 1;
>  my $email_maintainer = 1;
>  my $email_reviewer = 1;
>  my $email_fixes = 1;
> +my $email_mentioned = 0;
>  my $email_list = 1;
>  my $email_moderated_list = 1;
>  my $email_subscriber_list = 0;
> @@ -78,6 +79,7 @@ my $exit = 0;
>  
>  my @files = ();
>  my @fixes = ();			# If a patch description includes Fixes: lines
> +my @mentioned = ();		# If a patch description mentiones a patch
>  my @range = ();
>  my @keyword_tvi = ();
>  my @file_emails = ();
> @@ -264,6 +266,7 @@ if (!GetOptions(
>  		'n!' => \$email_usename,
>  		'l!' => \$email_list,
>  		'fixes!' => \$email_fixes,
> +		'mentioned!' => \$email_mentioned,
>  		'moderated!' => \$email_moderated_list,
>  		's!' => \$email_subscriber_list,
>  		'multiline!' => \$output_multiline,
> @@ -606,6 +609,8 @@ foreach my $file (@ARGV) {
>  		push(@files, $filename2);
>  	    } elsif (m/^Fixes:\s+([0-9a-fA-F]{6,40})/) {
>  		push(@fixes, $1) if ($email_fixes);
> +	    } elsif (m/\s+([0-9a-fA-F]{6,40})/) {
> +		push(@mentioned, $1) if ($email_mentioned);

If you still wanna submit this patch anyway, besides explaining the
reason to be accepted, I think you should check if your regex isn't
matching anything other than commit messages. For instance, I can easily
imagine this regex matching a regular hash that's not a commit id or a
memory address.

Imagine you have a kernel panic log in the commit message, for instance.
I think your script would likely misinterpret register values as commit
messages.

Really need to work on that. Though I would recommend that you discuss
with the list first and try to get people to understand why this might
be important first so you don't waste time fixing something that might
not get accepted. Unless you wanna use it for yourself locally.

-- 
Agatha Isabelle Moreira
C Developer | agatha.dev
Sourcehut: https://sr.ht/~devlavender/

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies