All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Add quirk for HP 255 15.6 inch G9 Notebook PC
@ 2026-05-07 20:27 furstblumier
  2026-05-11 18:16 ` Fürst Blumier
  2026-06-09 19:54 ` furstblumier
  0 siblings, 2 replies; 6+ messages in thread
From: furstblumier @ 2026-05-07 20:27 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, furstblumier

Signed-off-by: furstblumier <seal@furst.blue>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 11d0ea8ed..08c8b17b7 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7063,6 +7063,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
 	SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a1b, "HP 255 15.6 inch G9 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
 	SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
 	SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
 	SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add quirk for HP 255 15.6 inch G9 Notebook PC
  2026-05-07 20:27 [PATCH] ALSA: hda/realtek: Add quirk for HP 255 15.6 inch G9 Notebook PC furstblumier
@ 2026-05-11 18:16 ` Fürst Blumier
  2026-06-09 18:40   ` Fürst Blumier
  2026-06-09 19:54 ` furstblumier
  1 sibling, 1 reply; 6+ messages in thread
From: Fürst Blumier @ 2026-05-11 18:16 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, perex

Hi,

Sorry, this is my first time contributing to a project like this, so it 
looks like my message body is missing and I just submitted the patch. 
Please bear with me and let me know if I did anything wrong.

This patch fixes an issue with the headphone jack detection on my HP 255 
15.6 inch G9 Notebook PC. Specifically with this patch plugging and 
unplugging the headphone jack now correctly switches audio sinks on 
pulseaudio and also fixes the LED of the mute button not lighting up at all.

This has been tested on my own hardware under kernel 7.0.3-arch1-2. If 
you need any more information or need me to change something please let 
me know!

Thank you for your time and work.

On 5/7/26 10:27 PM, furstblumier wrote:
> Signed-off-by: furstblumier <seal@furst.blue>
> ---
>   sound/hda/codecs/realtek/alc269.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 11d0ea8ed..08c8b17b7 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7063,6 +7063,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>   	SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
>   	SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8a1b, "HP 255 15.6 inch G9 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>   	SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>   	SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>   	SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add quirk for HP 255 15.6 inch G9 Notebook PC
  2026-05-11 18:16 ` Fürst Blumier
@ 2026-06-09 18:40   ` Fürst Blumier
  2026-06-09 18:57     ` Geraldo Nascimento
  0 siblings, 1 reply; 6+ messages in thread
From: Fürst Blumier @ 2026-06-09 18:40 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, perex

Hi,

I haven't heard back in a month about this so I wanted to ask if there 
are any changes you'd like to see or if I have to submit the patch 
differently, since this is the first time I'm contributing here.

If you'd like me to resubmit the patch, I can do that as well. Thank you 
for your work!

Best,

Fürst Blumier

On 5/11/26 8:16 PM, Fürst Blumier wrote:
> Hi,
>
> Sorry, this is my first time contributing to a project like this, so 
> it looks like my message body is missing and I just submitted the 
> patch. Please bear with me and let me know if I did anything wrong.
>
> This patch fixes an issue with the headphone jack detection on my HP 
> 255 15.6 inch G9 Notebook PC. Specifically with this patch plugging 
> and unplugging the headphone jack now correctly switches audio sinks 
> on pulseaudio and also fixes the LED of the mute button not lighting 
> up at all.
>
> This has been tested on my own hardware under kernel 7.0.3-arch1-2. If 
> you need any more information or need me to change something please 
> let me know!
>
> Thank you for your time and work.
>
> On 5/7/26 10:27 PM, furstblumier wrote:
>> Signed-off-by: furstblumier <seal@furst.blue>
>> ---
>>   sound/hda/codecs/realtek/alc269.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/hda/codecs/realtek/alc269.c 
>> b/sound/hda/codecs/realtek/alc269.c
>> index 11d0ea8ed..08c8b17b7 100644
>> --- a/sound/hda/codecs/realtek/alc269.c
>> +++ b/sound/hda/codecs/realtek/alc269.c
>> @@ -7063,6 +7063,7 @@ static const struct hda_quirk 
>> alc269_fixup_tbl[] = {
>>       SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", 
>> ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
>>       SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", 
>> ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>>       SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", 
>> ALC287_FIXUP_HP_GPIO_LED),
>> +    SND_PCI_QUIRK(0x103c, 0x8a1b, "HP 255 15.6 inch G9 Notebook PC", 
>> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>>       SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx", 
>> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>>       SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", 
>> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>>       SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", 
>> ALC245_FIXUP_HP_MUTE_LED_COEFBIT),

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add quirk for HP 255 15.6 inch G9 Notebook PC
  2026-06-09 18:40   ` Fürst Blumier
@ 2026-06-09 18:57     ` Geraldo Nascimento
  0 siblings, 0 replies; 6+ messages in thread
From: Geraldo Nascimento @ 2026-06-09 18:57 UTC (permalink / raw)
  To: Fürst Blumier; +Cc: alsa-devel, tiwai, perex

Hi Furst,

On Tue, Jun 09, 2026 at 08:40:04PM +0200, Fürst Blumier wrote:
> Hi,
> 
> I haven't heard back in a month about this so I wanted to ask if there 
> are any changes you'd like to see or if I have to submit the patch 
> differently, since this is the first time I'm contributing here.

Please provide a commit message sufficiently descriptive of your
changes. Patches should be Cc:ed for linux-sound mailing list, not
alsa-devel.

Last but not least, do not concatenate your first and last
name in the Signed-off-by. The patch itself looks OK.

Thanks,
Geraldo Nascimento

> 
> If you'd like me to resubmit the patch, I can do that as well. Thank you 
> for your work!
> 
> Best,
> 
> Fürst Blumier

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ALSA: hda/realtek: Add quirk for HP 255 15.6 inch G9 Notebook PC
  2026-05-07 20:27 [PATCH] ALSA: hda/realtek: Add quirk for HP 255 15.6 inch G9 Notebook PC furstblumier
  2026-05-11 18:16 ` Fürst Blumier
@ 2026-06-09 19:54 ` furstblumier
  2026-06-09 20:02   ` Geraldo Nascimento
  1 sibling, 1 reply; 6+ messages in thread
From: furstblumier @ 2026-06-09 19:54 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, perex, linux-sound, furstblumier

The HP 255 15.6 inch G9 Notebook PC (PCI SSID 103c:8a1b) uses the
ALC236 codec but lacks an entry in the quirk table, causing the kernel
to fall back to a null SSID match (103c:0000) and skip the necessary
fixup. Add a quirk entry using ALC236_FIXUP_HP_MUTE_LED_COEFBIT2,
matching the HP 255 G8 which uses the same codec and fixup. This fixes
the mute-button LED and fixes an issue with unplugging and replugging a
headset jack not being recognized as an audio sink.

Signed-off-by: Furst Blumier <seal@furst.blue>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 11d0ea8ed..08c8b17b7 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7063,6 +7063,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
 	SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a1b, "HP 255 15.6 inch G9 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
 	SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
 	SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
 	SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add quirk for HP 255 15.6 inch G9 Notebook PC
  2026-06-09 19:54 ` furstblumier
@ 2026-06-09 20:02   ` Geraldo Nascimento
  0 siblings, 0 replies; 6+ messages in thread
From: Geraldo Nascimento @ 2026-06-09 20:02 UTC (permalink / raw)
  To: furstblumier; +Cc: alsa-devel, tiwai, perex, linux-sound

Hi Furst

On Tue, Jun 09, 2026 at 09:54:43PM +0200, furstblumier wrote:
> The HP 255 15.6 inch G9 Notebook PC (PCI SSID 103c:8a1b) uses the
> ALC236 codec but lacks an entry in the quirk table, causing the kernel
> to fall back to a null SSID match (103c:0000) and skip the necessary
> fixup. Add a quirk entry using ALC236_FIXUP_HP_MUTE_LED_COEFBIT2,
> matching the HP 255 G8 which uses the same codec and fixup. This fixes
> the mute-button LED and fixes an issue with unplugging and replugging a
> headset jack not being recognized as an audio sink.
> 
> Signed-off-by: Furst Blumier <seal@furst.blue>
> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 11d0ea8ed..08c8b17b7 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7063,6 +7063,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
>  	SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8a1b, "HP 255 15.6 inch G9 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>  	SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>  	SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>  	SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
> -- 
> 2.54.0
> 

The body of the patch and all metadata are now correct but you replied
to your own message (that has been previously ignored) with the patch.

Please don't do this.

Please resend patches in their own thread, with the RESEND marker.

If in doubt about the kernel process, consult https://docs.kernel.org


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-06-09 20:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-07 20:27 [PATCH] ALSA: hda/realtek: Add quirk for HP 255 15.6 inch G9 Notebook PC furstblumier
2026-05-11 18:16 ` Fürst Blumier
2026-06-09 18:40   ` Fürst Blumier
2026-06-09 18:57     ` Geraldo Nascimento
2026-06-09 19:54 ` furstblumier
2026-06-09 20:02   ` Geraldo Nascimento

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.