From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Rodrigo Alencar <455.rodrigo.alencar@gmail.com>
Cc: rodrigo.alencar@analog.com,
Michael Auchter <michael.auchter@ni.com>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: [PATCH v2 12/12] iio: dac: ad5686: add gain control support
Date: Wed, 10 Jun 2026 13:44:30 +0300 [thread overview]
Message-ID: <ailADpIf3GY2Ph2H@ashevche-desk.local> (raw)
In-Reply-To: <kzfu37rchq7zjus7jpsy745zfvw3zvpz57l7yqvddolwhb4yth@c7qx3pdq7tjy>
On Wed, Jun 10, 2026 at 09:25:25AM +0100, Rodrigo Alencar wrote:
> On 09/06/26 21:15, Andy Shevchenko wrote:
> > On Tue, Jun 09, 2026 at 11:13:07AM +0100, Rodrigo Alencar via B4 Relay wrote:
...
> > > + unsigned short vref_mv;
> >
> > _mV
>
> Renaming would need to be a separate refactoring patch. I'll just keep
> as is and just have the field moved down.
I haven't noticed that it is in the original code. Yeah, in such a case it's
fine as is.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-06-10 10:44 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 10:12 [PATCH v2 00/12] New features for the AD5686 IIO driver Rodrigo Alencar
2026-06-09 10:12 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:12 ` [PATCH v2 01/12] dt-bindings: iio: dac: ad5696: add reset/ldac/gain gpio support Rodrigo Alencar
2026-06-09 10:12 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:12 ` [PATCH v2 02/12] dt-bindings: iio: dac: ad5696: rework on power supplies Rodrigo Alencar
2026-06-09 10:12 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:28 ` sashiko-bot
2026-06-09 11:40 ` Rodrigo Alencar
2026-06-09 16:12 ` Conor Dooley
2026-06-14 17:24 ` Jonathan Cameron
2026-06-09 10:12 ` [PATCH v2 03/12] dt-bindings: iio: dac: ad5686: add reset/ldac/gain gpio support Rodrigo Alencar
2026-06-09 10:12 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:12 ` [PATCH v2 04/12] dt-bindings: iio: dac: ad5686: rework on power supplies Rodrigo Alencar
2026-06-09 10:12 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:22 ` sashiko-bot
2026-06-09 10:13 ` [PATCH v2 05/12] iio: dac: ad5686: add support for missing " Rodrigo Alencar
2026-06-09 10:13 ` Rodrigo Alencar via B4 Relay
2026-06-14 17:29 ` Jonathan Cameron
2026-06-09 10:13 ` [PATCH v2 06/12] iio: dac: ad5686: consume optional reset signal Rodrigo Alencar
2026-06-09 10:13 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:29 ` sashiko-bot
2026-06-09 11:17 ` Rodrigo Alencar
2026-06-14 17:33 ` Jonathan Cameron
2026-06-09 10:13 ` [PATCH v2 07/12] iio: dac: ad5686: add ldac gpio Rodrigo Alencar
2026-06-09 10:13 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:13 ` [PATCH v2 08/12] iio: dac: ad5686: introduce sync operation Rodrigo Alencar
2026-06-09 10:13 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:13 ` [PATCH v2 09/12] iio: dac: ad5686: implement new sync() op for the spi bus Rodrigo Alencar
2026-06-09 10:13 ` Rodrigo Alencar via B4 Relay
2026-06-09 18:10 ` Andy Shevchenko
2026-06-09 10:13 ` [PATCH v2 10/12] iio: dac: ad5686: add triggered buffer support Rodrigo Alencar
2026-06-09 10:13 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:13 ` [PATCH v2 11/12] iio: dac: ad5686: write_raw: use guard(mutex)() Rodrigo Alencar
2026-06-09 10:13 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:26 ` Joshua Crofts
2026-06-09 11:46 ` Nuno Sá
2026-06-09 22:13 ` Maxwell Doose
2026-06-09 22:17 ` Maxwell Doose
2026-06-14 17:38 ` Jonathan Cameron
2026-06-09 10:13 ` [PATCH v2 12/12] iio: dac: ad5686: add gain control support Rodrigo Alencar
2026-06-09 10:13 ` Rodrigo Alencar via B4 Relay
2026-06-09 10:37 ` sashiko-bot
2026-06-09 11:10 ` Rodrigo Alencar
2026-06-14 17:49 ` Jonathan Cameron
2026-06-09 18:15 ` Andy Shevchenko
2026-06-10 8:25 ` Rodrigo Alencar
2026-06-10 10:44 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ailADpIf3GY2Ph2H@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=455.rodrigo.alencar@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavoars@kernel.org \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=michael.auchter@ni.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.