From: Sean Christopherson <seanjc@google.com>
To: sashiko-reviews@lists.linux.dev
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v6 09/18] KVM: selftests: Verify interrupts are received when IRQ affinity changes in IRQ test
Date: Wed, 10 Jun 2026 12:20:32 -0700 [thread overview]
Message-ID: <aim5AGJwj6tlkigX@google.com> (raw)
In-Reply-To: <20260610010658.1E0501F00898@smtp.kernel.org>
On Wed, Jun 10, 2026, sashiko-bot@kernel.org wrote:
> > @@ -192,7 +198,12 @@ int main(int argc, char **argv)
> > printf("Using device %s MSI-X[%d] (IRQ-%u)\n", device_bdf, msix,
> > irq);
> > } else {
> > + TEST_ASSERT(!irq_affinity,
> > + "Setting IRQ affinity (-a) requires a backing device (-d)");
> > +
> > eventfd = kvm_new_eventfd();
> > + irq = -1;
> > + irq_cpu = -1;
> > }
>
> [Severity: Low]
> Is irq_cpu used uninitialized here when the test is run with -d but without -a?
>
> When a backing device is specified (-d), the code enters the if (device_bdf)
> block and irq_cpu remains uninitialized. If a vCPU times out waiting for an
> interrupt, the TEST_ASSERT macro evaluates and passes the uninitialized
> irq_cpu to the variadic format string, printing garbage values.
Gah, I meant to initialize it to -1 (hence the signed %d instead of %u).
next prev parent reply other threads:[~2026-06-10 19:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 0:53 [PATCH v6 00/18] KVM: selftests: Add eventfd+VFIO IRQ test Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 01/18] KVM: selftests: Build and link selftests/vfio/lib into KVM selftests Sean Christopherson
2026-06-10 1:03 ` sashiko-bot
2026-06-10 19:18 ` Sean Christopherson
2026-06-10 20:14 ` David Matlack
2026-06-10 20:15 ` David Matlack
2026-06-11 0:29 ` Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 02/18] KVM: selftests: Add macros to read/write+sync to/from guest memory Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 03/18] KVM: selftests: Rename guest_rng to kvm_rng Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 04/18] KVM: selftests: Add helper to generate random u64 in range [min,max] Sean Christopherson
2026-06-10 1:01 ` sashiko-bot
2026-06-10 0:53 ` [PATCH v6 05/18] KVM: selftests: Add an irqfd send+receive (and later IRQ bypass) test Sean Christopherson
2026-06-10 1:08 ` sashiko-bot
2026-06-10 19:35 ` Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 06/18] KVM: selftests: Add helper to get host IRQ from device MSI-X for IRQ bypass test Sean Christopherson
2026-06-10 1:01 ` sashiko-bot
2026-06-10 0:53 ` [PATCH v6 07/18] KVM: selftests: Add VFIO device support to eventfd IRQ test Sean Christopherson
2026-06-10 1:05 ` sashiko-bot
2026-06-10 18:06 ` Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 08/18] KVM: selftests: Add a helper to set proc IRQ affinity for " Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 09/18] KVM: selftests: Verify interrupts are received when IRQ affinity changes in " Sean Christopherson
2026-06-10 1:06 ` sashiko-bot
2026-06-10 19:20 ` Sean Christopherson [this message]
2026-06-10 0:53 ` [PATCH v6 10/18] KVM: selftests: Add option to set empty routing between IRQs in eventfd " Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 11/18] KVM: selftests: Make number of IRQs configurable in " Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 12/18] KVM: selftests: Verify non-postable IRQ remapping " Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 13/18] KVM: selftests: Add kvm_gettid() wrapper and convert users Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 14/18] KVM: selftests: Add kvm_sched_getaffinity() " Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 15/18] KVM: selftests: Add a utility to pin a task to a random CPU, given a CPU set Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 16/18] KVM: selftests: Verify vCPU migration during IRQ delivery in IRQ test Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 17/18] KVM: selftests: Make number of vCPUs configurable " Sean Christopherson
2026-06-10 0:53 ` [PATCH v6 18/18] KVM: selftests: Add xAPIC support in eventfd " Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aim5AGJwj6tlkigX@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.