Re: [PATCH v6 01/18] KVM: selftests: Build and link selftests/vfio/lib into KVM selftests

[Sean Christopherson <seanjc@google.com>]

On Wed, Jun 10, 2026, David Matlack wrote:
> On Wed, Jun 10, 2026 at 1:15 PM David Matlack <dmatlack@google.com> wrote:
> >
> > On 2026-06-10 12:18 PM, Sean Christopherson wrote:
> > > On Wed, Jun 10, 2026, sashiko-bot@kernel.org wrote:
> > > > > diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm
> > > > > index e0ddd3ff9472d..14316358fd9fb 100644
> > > > > --- a/tools/testing/selftests/kvm/Makefile.kvm
> > > > > +++ b/tools/testing/selftests/kvm/Makefile.kvm
> > > > > @@ -257,6 +257,7 @@ OVERRIDE_TARGETS = 1
> > > > >  # which causes the environment variable to override the makefile).
> > > > >  include ../lib.mk
> > > > >  include ../cgroup/lib/libcgroup.mk
> > > > > +include ../vfio/lib/libvfio.mk
> > > >
> > > > [Severity: Low]
> > > > Does including libvfio.mk here break the "make clean all" sequence for KVM
> > > > selftests?
> > >
> > > David and/or Josh, can you verify whether Sashiko is hallucinating or has a
> > > legitimate concern?
> >
> > That is a legitimate bug in libvfio.mk. Want me to send a separate patch
> > to fix (see below) or do you want to include as part of your series?

If the bug can be hit without this series, send a separate patch.  If it's only
relevant once this series lands, probably makes sense to include it here?

> > diff --git a/tools/testing/selftests/vfio/lib/libvfio.mk b/tools/testing/selftests/vfio/lib/libvfio.mk
> > index 9f47bceed16f..1f1ab180f42d 100644
> > --- a/tools/testing/selftests/vfio/lib/libvfio.mk
> > +++ b/tools/testing/selftests/vfio/lib/libvfio.mk
> > @@ -21,9 +21,12 @@ LIBVFIO_O := $(patsubst %.c, $(LIBVFIO_OUTPUT)/%.o, $(LIBVFIO_C))
> >  LIBVFIO_O_DIRS := $(shell dirname $(LIBVFIO_O) | uniq)
> >  $(shell mkdir -p $(LIBVFIO_O_DIRS))
> 
> (Forgot to delete this line but you get the idea.)
> 
> >
> > +$(LIBVFIO_O_DIRS):
> > +       mkdir -p $@
> > +
> >  CFLAGS += -I$(LIBVFIO_SRCDIR)/include
> >
> > -$(LIBVFIO_O): $(LIBVFIO_OUTPUT)/%.o : $(LIBVFIO_SRCDIR)/%.c
> > +$(LIBVFIO_O): $(LIBVFIO_OUTPUT)/%.o : $(LIBVFIO_SRCDIR)/%.c $(LIBVFIO_O_DIRS)
> >         $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c $< -o $@
> >
> >  EXTRA_CLEAN += $(LIBVFIO_OUTPUT)
> >