From: Thorsten Blum <thorsten.blum@linux.dev>
To: Mike Marshall <hubcap@omnibond.com>,
Martin Brandenburg <martin@omnibond.com>
Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] orangefs: Remove commented out code in find_cached_xattr
Date: Fri, 12 Jun 2026 00:08:52 +0200 [thread overview]
Message-ID: <aisx9DUs7Pr128f1@linux.dev> (raw)
In-Reply-To: <20251221124713.171813-2-thorsten.blum@linux.dev>
Gentle ping or do you prefer to keep this for some reason?
On Sun, Dec 21, 2025 at 01:47:13PM +0100, Thorsten Blum wrote:
> The code has been commented out since 2017 - remove it.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> fs/orangefs/xattr.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/orangefs/xattr.c b/fs/orangefs/xattr.c
> index eee3c5ed1bbb..4043942a3c33 100644
> --- a/fs/orangefs/xattr.c
> +++ b/fs/orangefs/xattr.c
> @@ -72,11 +72,6 @@ static struct orangefs_cached_xattr *find_cached_xattr(struct inode *inode,
> if (hlist_empty(h))
> return NULL;
> hlist_for_each_entry_safe(cx, tmp, h, node) {
> -/* if (!time_before(jiffies, cx->timeout)) {
> - hlist_del(&cx->node);
> - kfree(cx);
> - continue;
> - }*/
> if (!strcmp(cx->key, key))
> return cx;
> }
prev parent reply other threads:[~2026-06-11 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 12:47 [PATCH] orangefs: Remove commented out code in find_cached_xattr Thorsten Blum
2026-06-11 22:08 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aisx9DUs7Pr128f1@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=devel@lists.orangefs.org \
--cc=hubcap@omnibond.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.