All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Oleksii Kurochko <oleksii.kurochko@gmail.com>
Subject: Re: [PATCH for-4.22? 9/9] x86/HVM: more checking for XEN_DOMCTL_ioport_mapping
Date: Tue, 16 Jun 2026 12:01:51 +0200	[thread overview]
Message-ID: <ajEfD57XLXUEppCo@macbook.local> (raw)
In-Reply-To: <b0a50973-7a84-4e69-8241-d761e9b887dc@suse.com>

On Mon, Jun 15, 2026 at 04:16:41PM +0200, Jan Beulich wrote:
> When adding ranges, only alter existing ones when there is an exact match.
> Don't accept ranges overlapping existing ones.
> 
> When removing ranges, only remove a range if there's an exact match.
> Return an error when the range isn't found, and also don't call
> ioports_deny_access() in that case.

Isn't the ioports_deny_access() part stale now?  As you remove the
permission adjustments in patch 8/9.

> Fixes: 192c4dabc344 ("domctl and p2m changes for PCI passthru")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> Should "exact match" perhaps also include the guest port number? I'm
> uncertain here as that kind of conflicts with "add" being treated as
> "change" when the host port (and now count) match.

I think we want to keep the existing behavior and allow using an add
operation to change the guest port.

Thanks, Roger.


  reply	other threads:[~2026-06-16 10:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15 14:11 [PATCH for-4.22? 0/9] domctl: XSA-492 and -491 follow-on Jan Beulich
2026-06-15 14:12 ` [PATCH for-4.22? 1/9] sched: introduce specialization of "running only" vcpu_runstate_get() Jan Beulich
2026-06-16  8:41   ` Roger Pau Monné
2026-06-16  8:48     ` Jan Beulich
2026-06-16  9:21   ` Jürgen Groß
2026-06-15 14:12 ` [PATCH for-4.22? 2/9] domctl: move XEN_DOMCTL_irq_permission handling to x86 code Jan Beulich
2026-06-16  7:22   ` Oleksii Kurochko
2026-06-15 14:13 ` [PATCH for-4.22? 3/9] domctl: rename a label Jan Beulich
2026-06-16  7:23   ` Oleksii Kurochko
2026-06-16  8:43   ` Roger Pau Monné
2026-06-15 14:13 ` [PATCH for-4.22? 4/9] domctl: error code adjustment for unpriv callers Jan Beulich
2026-06-16  7:27   ` Oleksii Kurochko
2026-06-15 14:13 ` [PATCH for-4.22? 5/9] domctl/XSM: avoid XSM_OTHER with xsm_domctl() Jan Beulich
2026-06-15 20:57   ` Daniel P. Smith
2026-06-15 14:15 ` [PATCH for-4.22? 6/9] domctl: handle XEN_DOMCTL_getvcpuinfo without acquiring domctl lock Jan Beulich
2026-06-16  8:56   ` Roger Pau Monné
2026-06-16  9:08     ` Jan Beulich
2026-06-15 14:15 ` [PATCH for-4.22? 7/9] domctl: restrict permission check for XEN_DOMCTL_memory_mapping's remove form Jan Beulich
2026-06-16  9:08   ` Roger Pau Monné
2026-06-16  9:51     ` Jan Beulich
2026-06-16 10:06       ` Roger Pau Monné
2026-06-15 14:16 ` [PATCH for-4.22? 8/9] x86/domctl: don't imply I/O port permissions from I/O port mapping Jan Beulich
2026-06-16  9:21   ` Roger Pau Monné
2026-06-16  9:36     ` Jan Beulich
2026-06-16 10:09       ` Roger Pau Monné
2026-06-15 14:16 ` [PATCH for-4.22? 9/9] x86/HVM: more checking for XEN_DOMCTL_ioport_mapping Jan Beulich
2026-06-16 10:01   ` Roger Pau Monné [this message]
2026-06-16 10:07     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajEfD57XLXUEppCo@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=oleksii.kurochko@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.