* [PATCH] scripts: Getting rid of -h option, when empty, the usage will be shown
@ 2026-06-07 23:20 Bhaskar Chowdhury
2026-06-11 13:41 ` Matthieu Baerts
0 siblings, 1 reply; 4+ messages in thread
From: Bhaskar Chowdhury @ 2026-06-07 23:20 UTC (permalink / raw)
To: unixbhaskar, matttbe, akpm, luca.ceresoli, cmllamas, mhiramat,
linux-kernel
cc:sashal@kernel.org
Make thing simple to show the help/usage info, when no argument given.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
scripts/decode_stacktrace.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
index 39d60d477bf3..fa084f128802 100755
--- a/scripts/decode_stacktrace.sh
+++ b/scripts/decode_stacktrace.sh
@@ -7,7 +7,6 @@ usage() {
echo "Usage:"
echo " $0 [-R] -r <release>"
echo " $0 [-R] [<vmlinux> [<base_path>|auto [<modules_path>]]]"
- echo " $0 -h"
echo "Options:"
echo " -R: decode return address instead of caller address."
}
@@ -37,7 +36,7 @@ ADDR2LINE=${UTIL_PREFIX}addr2line${UTIL_SUFFIX}
NM=${UTIL_PREFIX}nm${UTIL_SUFFIX}
decode_retaddr=false
-if [[ $1 == "-h" ]] ; then
+if [[ $1 == "" ]] ; then
usage
exit 0
elif [[ $1 == "-R" ]] ; then
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts: Getting rid of -h option, when empty, the usage will be shown
2026-06-07 23:20 [PATCH] scripts: Getting rid of -h option, when empty, the usage will be shown Bhaskar Chowdhury
@ 2026-06-11 13:41 ` Matthieu Baerts
[not found] ` <20260613233012.3245472-2-unixbhaskar@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Matthieu Baerts @ 2026-06-11 13:41 UTC (permalink / raw)
To: Bhaskar Chowdhury
Cc: akpm, luca.ceresoli, cmllamas, mhiramat, linux-kernel,
Sasha Levin
Hi Bhaskar,
On 08/06/2026 01:20, Bhaskar Chowdhury wrote:
> cc:sashal@kernel.org
Sasha was not in Cc. You need you write "Cc: ..." instead for
git-send-email to add someone in Cc
> Make thing simple to show the help/usage info, when no argument given.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> scripts/decode_stacktrace.sh | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index 39d60d477bf3..fa084f128802 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -7,7 +7,6 @@ usage() {
> echo "Usage:"
> echo " $0 [-R] -r <release>"
> echo " $0 [-R] [<vmlinux> [<base_path>|auto [<modules_path>]]]"
As mentioned on this line above, this script can be called without any
argument.
So, if I'm not mistaken, the modification you are suggesting here cannot
be accepted.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] scripts: Getting rid of -h option, when empty, the usage will be shown
[not found] ` <20260613233012.3245472-2-unixbhaskar@gmail.com>
@ 2026-06-13 23:24 ` Bhaskar Chowdhury
2026-06-17 14:18 ` Sasha Levin
0 siblings, 1 reply; 4+ messages in thread
From: Bhaskar Chowdhury @ 2026-06-13 23:24 UTC (permalink / raw)
To: matttbe
Cc: akpm, cmllamas, linux-kernel, luca.ceresoli, mhiramat, sashal,
unixbhaskar
cc:sashal@kernel.org
Make thing simple to show the help/usage info, when no argument given.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
scripts/decode_stacktrace.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
index 39d60d477bf3..fa084f128802 100755
--- a/scripts/decode_stacktrace.sh
+++ b/scripts/decode_stacktrace.sh
@@ -7,7 +7,6 @@ usage() {
echo "Usage:"
echo " $0 [-R] -r <release>"
echo " $0 [-R] [<vmlinux> [<base_path>|auto [<modules_path>]]]"
- echo " $0 -h"
echo "Options:"
echo " -R: decode return address instead of caller address."
}
@@ -37,7 +36,7 @@ ADDR2LINE=${UTIL_PREFIX}addr2line${UTIL_SUFFIX}
NM=${UTIL_PREFIX}nm${UTIL_SUFFIX}
decode_retaddr=false
-if [[ $1 == "-h" ]] ; then
+if [[ $1 == "" ]] ; then
usage
exit 0
elif [[ $1 == "-R" ]] ; then
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts: Getting rid of -h option, when empty, the usage will be shown
2026-06-13 23:24 ` Bhaskar Chowdhury
@ 2026-06-17 14:18 ` Sasha Levin
0 siblings, 0 replies; 4+ messages in thread
From: Sasha Levin @ 2026-06-17 14:18 UTC (permalink / raw)
To: Bhaskar Chowdhury
Cc: matttbe, akpm, cmllamas, linux-kernel, luca.ceresoli, mhiramat
On Sun, Jun 14, 2026 at 04:54:46AM +0530, Bhaskar Chowdhury wrote:
>cc:sashal@kernel.org
>
>Make thing simple to show the help/usage info, when no argument given.
But passing no arguments is a valid thing to do for this script...
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-17 14:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-07 23:20 [PATCH] scripts: Getting rid of -h option, when empty, the usage will be shown Bhaskar Chowdhury
2026-06-11 13:41 ` Matthieu Baerts
[not found] ` <20260613233012.3245472-2-unixbhaskar@gmail.com>
2026-06-13 23:24 ` Bhaskar Chowdhury
2026-06-17 14:18 ` Sasha Levin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.