* [PATCH v1] platform/chrome: Drop unused assignment of platform_device_id driver data
@ 2026-06-17 10:04 Uwe Kleine-König (The Capable Hub)
2026-06-18 4:09 ` Tzung-Bi Shih
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-06-17 10:04 UTC (permalink / raw)
To: Benson Leung, Tzung-Bi Shih, Łukasz Bartosik,
Andrei Kuchynski, Jameson Thies
Cc: Guenter Roeck, Liao Yuanhong, Kees Cook, chrome-platform,
linux-kernel
The drivers explicitly set the .driver_data member of struct
platform_device_id to zero without relying on that value. Drop these
unused assignments.
While touching these arrays use a single space in the list terminator
consistently.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
drivers/platform/chrome/cros_ec_chardev.c | 4 ++--
drivers/platform/chrome/cros_ec_debugfs.c | 4 ++--
drivers/platform/chrome/cros_ec_lightbar.c | 4 ++--
drivers/platform/chrome/cros_ec_sensorhub.c | 4 ++--
drivers/platform/chrome/cros_ec_sysfs.c | 4 ++--
drivers/platform/chrome/cros_ec_vbc.c | 4 ++--
drivers/platform/chrome/cros_kbd_led_backlight.c | 4 ++--
drivers/platform/chrome/cros_usbpd_logger.c | 4 ++--
drivers/platform/chrome/cros_usbpd_notify.c | 4 ++--
drivers/platform/chrome/wilco_ec/core.c | 4 ++--
drivers/platform/chrome/wilco_ec/debugfs.c | 4 ++--
drivers/platform/chrome/wilco_ec/telemetry.c | 4 ++--
12 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_chardev.c b/drivers/platform/chrome/cros_ec_chardev.c
index 47e03014dcbe..2565510ecaa7 100644
--- a/drivers/platform/chrome/cros_ec_chardev.c
+++ b/drivers/platform/chrome/cros_ec_chardev.c
@@ -485,8 +485,8 @@ static void cros_ec_chardev_remove(struct platform_device *pdev)
}
static const struct platform_device_id cros_ec_chardev_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, cros_ec_chardev_id);
diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
index d10f9561990c..4b8ae51bfaa9 100644
--- a/drivers/platform/chrome/cros_ec_debugfs.c
+++ b/drivers/platform/chrome/cros_ec_debugfs.c
@@ -558,8 +558,8 @@ static SIMPLE_DEV_PM_OPS(cros_ec_debugfs_pm_ops,
cros_ec_debugfs_suspend, cros_ec_debugfs_resume);
static const struct platform_device_id cros_ec_debugfs_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, cros_ec_debugfs_id);
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
index f69f2f6de276..d7e9928e263d 100644
--- a/drivers/platform/chrome/cros_ec_lightbar.c
+++ b/drivers/platform/chrome/cros_ec_lightbar.c
@@ -684,8 +684,8 @@ static SIMPLE_DEV_PM_OPS(cros_ec_lightbar_pm_ops,
cros_ec_lightbar_suspend, cros_ec_lightbar_resume);
static const struct platform_device_id cros_ec_lightbar_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, cros_ec_lightbar_id);
diff --git a/drivers/platform/chrome/cros_ec_sensorhub.c b/drivers/platform/chrome/cros_ec_sensorhub.c
index f938c3fc84e4..58eb28d6e118 100644
--- a/drivers/platform/chrome/cros_ec_sensorhub.c
+++ b/drivers/platform/chrome/cros_ec_sensorhub.c
@@ -268,8 +268,8 @@ static SIMPLE_DEV_PM_OPS(cros_ec_sensorhub_pm_ops,
cros_ec_sensorhub_resume);
static const struct platform_device_id cros_ec_sensorhub_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, cros_ec_sensorhub_id);
diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
index 9d3767ab1548..46e8ac7f94af 100644
--- a/drivers/platform/chrome/cros_ec_sysfs.c
+++ b/drivers/platform/chrome/cros_ec_sysfs.c
@@ -421,8 +421,8 @@ static void cros_ec_sysfs_remove(struct platform_device *pd)
}
static const struct platform_device_id cros_ec_sysfs_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, cros_ec_sysfs_id);
diff --git a/drivers/platform/chrome/cros_ec_vbc.c b/drivers/platform/chrome/cros_ec_vbc.c
index 5ee8adaa6564..9cb4631e1227 100644
--- a/drivers/platform/chrome/cros_ec_vbc.c
+++ b/drivers/platform/chrome/cros_ec_vbc.c
@@ -135,8 +135,8 @@ static void cros_ec_vbc_remove(struct platform_device *pd)
}
static const struct platform_device_id cros_ec_vbc_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, cros_ec_vbc_id);
diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/platform/chrome/cros_kbd_led_backlight.c
index 80dc52833dc9..7f7483d58170 100644
--- a/drivers/platform/chrome/cros_kbd_led_backlight.c
+++ b/drivers/platform/chrome/cros_kbd_led_backlight.c
@@ -221,8 +221,8 @@ MODULE_DEVICE_TABLE(acpi, keyboard_led_acpi_match);
#endif
static const struct platform_device_id keyboard_led_id[] = {
- { "cros-keyboard-leds", 0 },
- {}
+ { .name = "cros-keyboard-leds" },
+ { }
};
MODULE_DEVICE_TABLE(platform, keyboard_led_id);
diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
index d343e1ab6f08..54f04a43cba0 100644
--- a/drivers/platform/chrome/cros_usbpd_logger.c
+++ b/drivers/platform/chrome/cros_usbpd_logger.c
@@ -249,8 +249,8 @@ static SIMPLE_DEV_PM_OPS(cros_usbpd_logger_pm_ops, cros_usbpd_logger_suspend,
cros_usbpd_logger_resume);
static const struct platform_device_id cros_usbpd_logger_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, cros_usbpd_logger_id);
diff --git a/drivers/platform/chrome/cros_usbpd_notify.c b/drivers/platform/chrome/cros_usbpd_notify.c
index c90174360004..bdf3b2ab17a7 100644
--- a/drivers/platform/chrome/cros_usbpd_notify.c
+++ b/drivers/platform/chrome/cros_usbpd_notify.c
@@ -233,8 +233,8 @@ static void cros_usbpd_notify_remove_plat(struct platform_device *pdev)
}
static const struct platform_device_id cros_usbpd_notify_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, cros_usbpd_notify_id);
diff --git a/drivers/platform/chrome/wilco_ec/core.c b/drivers/platform/chrome/wilco_ec/core.c
index 9f978e531e1f..0b13f4509091 100644
--- a/drivers/platform/chrome/wilco_ec/core.c
+++ b/drivers/platform/chrome/wilco_ec/core.c
@@ -152,8 +152,8 @@ static const struct acpi_device_id wilco_ec_acpi_device_ids[] = {
MODULE_DEVICE_TABLE(acpi, wilco_ec_acpi_device_ids);
static const struct platform_device_id wilco_ec_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, wilco_ec_id);
diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c b/drivers/platform/chrome/wilco_ec/debugfs.c
index 0617292b5cd7..69f8ac4d64dd 100644
--- a/drivers/platform/chrome/wilco_ec/debugfs.c
+++ b/drivers/platform/chrome/wilco_ec/debugfs.c
@@ -266,8 +266,8 @@ static void wilco_ec_debugfs_remove(struct platform_device *pdev)
}
static const struct platform_device_id wilco_ec_debugfs_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, wilco_ec_debugfs_id);
diff --git a/drivers/platform/chrome/wilco_ec/telemetry.c b/drivers/platform/chrome/wilco_ec/telemetry.c
index cadb68fa0a40..ac4c5943da1f 100644
--- a/drivers/platform/chrome/wilco_ec/telemetry.c
+++ b/drivers/platform/chrome/wilco_ec/telemetry.c
@@ -410,8 +410,8 @@ static void telem_device_remove(struct platform_device *pdev)
}
static const struct platform_device_id telem_id[] = {
- { DRV_NAME, 0 },
- {}
+ { .name = DRV_NAME },
+ { }
};
MODULE_DEVICE_TABLE(platform, telem_id);
base-commit: 4fa3f5fabb30bf00d7475d5a33459ea83d639bf9
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] platform/chrome: Drop unused assignment of platform_device_id driver data
2026-06-17 10:04 [PATCH v1] platform/chrome: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
@ 2026-06-18 4:09 ` Tzung-Bi Shih
0 siblings, 0 replies; 2+ messages in thread
From: Tzung-Bi Shih @ 2026-06-18 4:09 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Benson Leung, Łukasz Bartosik, Andrei Kuchynski,
Jameson Thies, Guenter Roeck, Liao Yuanhong, Kees Cook,
chrome-platform, linux-kernel
On Wed, Jun 17, 2026 at 12:04:13PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The drivers explicitly set the .driver_data member of struct
> platform_device_id to zero without relying on that value. Drop these
> unused assignments.
>
> While touching these arrays use a single space in the list terminator
> consistently.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
For my reference,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-18 4:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-17 10:04 [PATCH v1] platform/chrome: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-06-18 4:09 ` Tzung-Bi Shih
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.