Re: [PATCH bpf-next 2/3] selftests/bpf: Add tracing_multi link info tests

[Jiri Olsa <olsajiri@gmail.com>]

On Sun, Jun 21, 2026 at 09:31:45PM +0000, bot+bpf-ci@kernel.org wrote:
> > diff --git a/tools/testing/selftests/bpf/prog_tests/fill_link_info.c b/tools/testing/selftests/bpf/prog_tests/fill_link_info.c
> > index f589eefbf9fb..969f04ee9ac6 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/fill_link_info.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/fill_link_info.c
> 
> [ ... ]
> 
> > @@ -396,6 +413,224 @@ static void test_kprobe_multi_fill_link_info(struct test_fill_link_info *skel,
> >  	bpf_link__destroy(link);
> >  }
> >
> > +static void verify_tracing_multi_invalid_user_buffer(int fd, const struct tmulti_target *targets)
> > +{
> > +	__u32 ids[TRACING_MULTI_CNT] = {};
> > +	struct bpf_link_info info;
> > +	__u32 len = sizeof(info);
> > +	int err, i;
> > +
> > +	/* Wrong info setup (ids != NULL and cnt == 0) -> EINVAL */
> > +	memset(&info, 0, sizeof(info));
> > +	info.tracing_multi.ids = ptr_to_u64(ids);
> > +	err = bpf_link_get_info_by_fd(fd, &info, &len);
> > +	ASSERT_EQ(err, -EINVAL, "tracing_multi.invalid_count");
> > +
> > +	/* Smaller than actuall count provided -> ENOSPC */
> 
> This isn't a bug, but "actuall" is misspelled here (should be "actual").
> 
> > +	memset(ids, 0, sizeof(ids));
> > +	memset(&info, 0, sizeof(info));
> > +	info.tracing_multi.ids = ptr_to_u64(ids);
> > +	info.tracing_multi.count = TRACING_MULTI_CNT - 1;
> > +	err = bpf_link_get_info_by_fd(fd, &info, &len);
> > +	ASSERT_EQ(err, -ENOSPC, "tracing_multi.small_count");
> > +	for (i = 0; i < TRACING_MULTI_CNT - 1; i++)
> > +		ASSERT_EQ(ids[i], targets[i].id, "tracing_multi.partial_ids");
> > +	/* check that the last entry is not populated */
> > +	ASSERT_EQ(ids[i], 0, "tracing_multi.partial_ids");
> > +
> > +	/* Bigger than actuall count provided -> OK */
> 
> The same typo appears here.

yep, will fix both

jirka

> 
> > +	memset(ids, 0, sizeof(ids));
> > +	memset(&info, 0, sizeof(info));
> > +	info.tracing_multi.ids = ptr_to_u64(ids);
> > +	info.tracing_multi.count = TRACING_MULTI_CNT + 1;
> > +	err = bpf_link_get_info_by_fd(fd, &info, &len);
> > +	ASSERT_OK(err, "tracing_multi.big_count");
> > +	for (i = 0; i < TRACING_MULTI_CNT; i++)
> > +		ASSERT_EQ(ids[i], targets[i].id, "tracing_multi.ids");
> 
> [ ... ]
> 
> 
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
> 
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/27917285330