From: Dan Carpenter <error27@gmail.com>
To: Aditya Chari <adi25charis@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove unused function declarations
Date: Tue, 23 Jun 2026 12:00:07 +0300 [thread overview]
Message-ID: <ajpLF34Tvh2u1TFe@stanley.mountain> (raw)
In-Reply-To: <20260622052543.61590-1-adi25charis@gmail.com>
On Mon, Jun 22, 2026 at 10:55:43AM +0530, Aditya Chari wrote:
> rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status()
> are declared in rtl8192c_recv.h but have no implementation and no
> caller anywhere in the kernel tree. They are leftover from when this
> driver was derived from Realtek's shared vendor codebase covering
> multiple chip families.
>
> Verified via grep across the full tree that neither symbol is
> referenced outside this declaration, and confirmed via a full build
> of the module before and after removal that no warnings or errors
> are introduced.
>
> This addresses the "find and remove any code for other chips that is
> left over" item in the driver's TODO file.
>
> Signed-off-by: Aditya Chari <adi25charis@gmail.com>
> ---
You're working against an old tree. Work against linux-next or
devel-next.
regards,
dan carpenter
next prev parent reply other threads:[~2026-06-23 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 5:25 [PATCH] staging: rtl8723bs: remove unused function declarations Aditya Chari
2026-06-23 9:00 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-21 22:33 Oskar Ray-Frayssinet
2026-03-23 4:47 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajpLF34Tvh2u1TFe@stanley.mountain \
--to=error27@gmail.com \
--cc=adi25charis@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.